Re: problem with LOCAL_MODULES

From: Gary Jennejohn <gljennjohn_at_gmail.com>
Date: Sat, 17 Aug 2019 09:46:27 +0200
On Fri, 16 Aug 2019 17:37:56 -0700
John Baldwin <jhb_at_FreeBSD.org> wrote:

> On 8/16/19 3:05 AM, Gary Jennejohn wrote:
> > I tried to build a kernel today and it failed in modules-all even
> > though I had LOCAL_MODULES="" in /etc/src.conf, as recommended by
> > jhb.
> > 
> > That's wrong.  It has to be LOCAL_MODULES=, otherwise
> > /sys/conf/kern.post.mk seems to conclude that there should be a
> > module under /usr/local/sys/modules with the name "".  
> 
> I think this will permit both versions to work:
> 
> Index: sys/conf/kern.post.mk
> ===================================================================
> --- kern.post.mk	(revision 351151)
> +++ kern.post.mk	(working copy)
> _at__at_ -76,6 +76,7 _at__at_ modules-${target}:
>  	cd $S/modules; ${MKMODULESENV} ${MAKE} \
>  	    ${target:S/^reinstall$/install/:S/^clobber$/cleandir/}
>  .endif
> +.if !empty(LOCAL_MODULES)
>  .for module in ${LOCAL_MODULES}
>  	_at_${ECHODIR} "===> ${module} (${target:S/^reinstall$/install/:S/^clobber$/cleandir/})"
>  	_at_cd ${LOCAL_MODULES_DIR}/${module}; ${MKMODULESENV} ${MAKE} \
> _at__at_ -83,6 +84,7 _at__at_ modules-${target}:
>  	    ${target:S/^reinstall$/install/:S/^clobber$/cleandir/}
>  .endfor
>  .endif
> +.endif
>  .endfor
>  
>  # Handle ports (as defined by the user) that build kernel modules
> 

Nope, the same error as before with the patch applied and
LOCAL_MODULES="" .

-- 
Gary Jennejohn
Received on Sat Aug 17 2019 - 05:46:31 UTC

This archive was generated by hypermail 2.4.0 : Wed May 19 2021 - 11:41:21 UTC