Re: drm2 removed?

On 2/11/19 5:12 PM, Steve Kargl wrote:
> Anyone have any idea which recent change broke the
> drm-legacy-kmod port.  This is why I raised an issue
> with removal of drm2 from src/sys.  How is suppose
> to be fixed?
> 
> 
> --- ttm_bo_manager.o ---
> cc  -O2 -pipe -march=core2 -fno-strict-aliasing -march=core2  -Werror -D_KERNEL -DKLD_MODULE -nostdinc  -I/usr/ports/graphics/drm-legacy-kmod/work/drm-legacy-50ea058/drm2/../src/ -I. -I/usr/src/sys -I/usr/src/sys/contrib/ck/include -fno-common     -MD  -MF.depend.ttm_bo_manager.o -MTttm_bo_manager.o -mno-mmx -mno-sse -msoft-float -ffreestanding -fwrapv -fstack-protector -Wall -Wredundant-decls -Wnested-externs -Wstrict-prototypes -Wmissing-prototypes -Wpointer-arith -Wcast-qual -Wundef -Wno-pointer-sign -D__printf__=__freebsd_kprintf__ -Wmissing-include-dirs -fdiagnostics-show-option -Wno-unknown-pragmas -Wno-error-tautological-compare -Wno-error-empty-body -Wno-error-parentheses-equality -Wno-error-unused-function -Wno-error-pointer-sign -Wno-error-shift-negative-value -Wno-address-of-packed-member  -mno-aes -mno-avx  -std=iso9899:1999 -c /usr/ports/graphics/drm-legacy-kmod/work/drm-legacy-50ea058/src/dev/drm2/ttm/ttm_bo_manager.c -o ttm_bo_manager.o
> --- ttm_bo.o ---
> /usr/ports/graphics/drm-legacy-kmod/work/drm-legacy-50ea058/src/dev/drm2/ttm/ttm_bo.c:1501:12: error: use of undeclared identifier 'NPGPTD'
>              1, 0, VM_MAX_ADDRESS, PAGE_SIZE, 0, VM_MEMATTR_UNCACHEABLE);
>                    ^
> ./machine/vmparam.h:173:31: note: expanded from macro 'VM_MAX_ADDRESS'
> #define VM_MAX_ADDRESS          VADDR(PTDPTDI, 0)
>                                        ^
> ./machine/pmap.h:122:19: note: expanded from macro 'PTDPTDI'
> #define PTDPTDI         (NPDEPTD - NTRPPTD - NPGPTD)
>                           ^
> ./machine/param.h:98:19: note: expanded from macro 'NPDEPTD'
> #define NPDEPTD         (NBPTD / sizeof(pd_entry_t))
>                           ^
> ./machine/param.h:96:17: note: expanded from macro 'NBPTD'
> #define NBPTD           (NPGPTD << PAGE_SHIFT)
>                           ^
> /usr/ports/graphics/drm-legacy-kmod/work/drm-legacy-50ea058/src/dev/drm2/ttm/ttm_bo.c:1501:12: error: use of undeclared identifier 'pd_entry_t'
> ./machine/vmparam.h:173:31: note: expanded from macro 'VM_MAX_ADDRESS'
> #define VM_MAX_ADDRESS          VADDR(PTDPTDI, 0)
>                                        ^
> ./machine/pmap.h:122:19: note: expanded from macro 'PTDPTDI'
> #define PTDPTDI         (NPDEPTD - NTRPPTD - NPGPTD)
>                           ^
> ./machine/param.h:98:34: note: expanded from macro 'NPDEPTD'
> #define NPDEPTD         (NBPTD / sizeof(pd_entry_t))
>                                          ^
> /usr/ports/graphics/drm-legacy-kmod/work/drm-legacy-50ea058/src/dev/drm2/ttm/ttm_bo.c:1501:12: error: use of undeclared identifier 'NTRPPTD'
> ./machine/vmparam.h:173:31: note: expanded from macro 'VM_MAX_ADDRESS'
> #define VM_MAX_ADDRESS          VADDR(PTDPTDI, 0)
>                                        ^
> ./machine/pmap.h:122:29: note: expanded from macro 'PTDPTDI'
> #define PTDPTDI         (NPDEPTD - NTRPPTD - NPGPTD)
>                                     ^
> /usr/ports/graphics/drm-legacy-kmod/work/drm-legacy-50ea058/src/dev/drm2/ttm/ttm_bo.c:1501:12: error: use of undeclared identifier 'NPGPTD'
> ./machine/vmparam.h:173:31: note: expanded from macro 'VM_MAX_ADDRESS'
> #define VM_MAX_ADDRESS          VADDR(PTDPTDI, 0)
>                                        ^
> ./machine/pmap.h:122:39: note: expanded from macro 'PTDPTDI'
> #define PTDPTDI         (NPDEPTD - NTRPPTD - NPGPTD)
>                                               ^
> /usr/ports/graphics/drm-legacy-kmod/work/drm-legacy-50ea058/src/dev/drm2/ttm/ttm_bo.c:1505:10: error: use of undeclared identifier 'NPGPTD'
>                      0, VM_MAX_ADDRESS, PAGE_SIZE, 0)) {
>                         ^
> ./machine/vmparam.h:173:31: note: expanded from macro 'VM_MAX_ADDRESS'
> #define VM_MAX_ADDRESS          VADDR(PTDPTDI, 0)
>                                        ^
> ./machine/pmap.h:122:19: note: expanded from macro 'PTDPTDI'
> #define PTDPTDI         (NPDEPTD - NTRPPTD - NPGPTD)
>                           ^
> ./machine/param.h:98:19: note: expanded from macro 'NPDEPTD'
> #define NPDEPTD         (NBPTD / sizeof(pd_entry_t))
>                           ^
> ./machine/param.h:96:17: note: expanded from macro 'NBPTD'
> #define NBPTD           (NPGPTD << PAGE_SHIFT)
>                           ^
> /usr/ports/graphics/drm-legacy-kmod/work/drm-legacy-50ea058/src/dev/drm2/ttm/ttm_bo.c:1505:10: error: use of undeclared identifier 'pd_entry_t'
> ./machine/vmparam.h:173:31: note: expanded from macro 'VM_MAX_ADDRESS'
> #define VM_MAX_ADDRESS          VADDR(PTDPTDI, 0)
>                                        ^
> ./machine/pmap.h:122:19: note: expanded from macro 'PTDPTDI'
> #define PTDPTDI         (NPDEPTD - NTRPPTD - NPGPTD)
>                           ^
> ./machine/param.h:98:34: note: expanded from macro 'NPDEPTD'
> #define NPDEPTD         (NBPTD / sizeof(pd_entry_t))
>                                          ^
> /usr/ports/graphics/drm-legacy-kmod/work/drm-legacy-50ea058/src/dev/drm2/ttm/ttm_bo.c:1505:10: error: use of undeclared identifier 'NTRPPTD'
> ./machine/vmparam.h:173:31: note: expanded from macro 'VM_MAX_ADDRESS'
> #define VM_MAX_ADDRESS          VADDR(PTDPTDI, 0)
>                                        ^
> ./machine/pmap.h:122:29: note: expanded from macro 'PTDPTDI'
> #define PTDPTDI         (NPDEPTD - NTRPPTD - NPGPTD)
>                                     ^
> /usr/ports/graphics/drm-legacy-kmod/work/drm-legacy-50ea058/src/dev/drm2/ttm/ttm_bo.c:1505:10: error: use of undeclared identifier 'NPGPTD'
> ./machine/vmparam.h:173:31: note: expanded from macro 'VM_MAX_ADDRESS'
> #define VM_MAX_ADDRESS          VADDR(PTDPTDI, 0)
>                                        ^
> ./machine/pmap.h:122:39: note: expanded from macro 'PTDPTDI'
> #define PTDPTDI         (NPDEPTD - NTRPPTD - NPGPTD)
>                                               ^
> 8 errors generated.
> *** [ttm_bo.o] Error code 1
> 
> make[4]: stopped in /usr/ports/graphics/drm-legacy-kmod/work/drm-legacy-50ea058/drm2/drm2
> 1 error
> 
> make[4]: stopped in /usr/ports/graphics/drm-legacy-kmod/work/drm-legacy-50ea058/drm2/drm2
> *** [all_subdir_drm2/drm2] Error code 2
> 
> make[3]: stopped in /usr/ports/graphics/drm-legacy-kmod/work/drm-legacy-50ea058/drm2
> 1 error
> 
> make[3]: stopped in /usr/ports/graphics/drm-legacy-kmod/work/drm-legacy-50ea058/drm2
> *** [all_subdir_drm2] Error code 2
> 
> make[2]: stopped in /usr/ports/graphics/drm-legacy-kmod/work/drm-legacy-50ea058
> 1 error
> 
> make[2]: stopped in /usr/ports/graphics/drm-legacy-kmod/work/drm-legacy-50ea058
> ===> Compilation failed unexpectedly.
> Try to set MAKE_JOBS_UNSAFE=yes and rebuild before reporting the failure to
> the maintainer.
> *** Error code 1
> 
> Stop.
> make[1]: stopped in /usr/ports/graphics/drm-legacy-kmod
> *** Error code 1
> 
> Stop.
> make: stopped in /usr/ports/graphics/drm-legacy-kmod
> 
> ===>>> make build failed for graphics/drm-legacy-kmod
> ===>>> Aborting update
> 
> 
> ===>>> You can restart from the point of failure with this command line:
>         portmaster <flags> graphics/drm-legacy-kmod
> 
> This command has been saved to /tmp/portmasterfail.txt
> 

Hi,

Looks like this commit removed the definitions you need:

https://svnweb.freebsd.org/changeset/base/343567

--HPS