revision 342699 breaks savecore when WITHOUT_DYNAMICROOT=yes is defined in src.conf amd64 current

From: Manfred Antar <manfredantar_at_gmail.com>
Date: Fri, 4 Jan 2019 11:14:55 -0800
sbin/savecore broken when WITHOUT_DYNAMICROOT is defined:

/usr/local/bin/ccache cc  -O2 -pipe   -DWITH_CASPER -MD  -MF.depend.savecore.o -MTsavecore.o -std=gnu99 -fstack-protector-strong -Wsystem-headers -Wall -Wno-format-y2k -W -Wno-unused-parameter -Wstrict-prototypes -Wmissing-prototypes -Wpointer-arith -Wreturn-type -Wcast-qual -Wwrite-strings -Wswitch -Wshadow -Wunused-parameter -Wcast-align -Wchar-subscripts -Winline -Wnested-externs -Wredundant-decls -Wold-style-definition -Wno-pointer-sign -Wmissing-variable-declarations -Wthread-safety -Wno-empty-body -Wno-string-plus-int -Wno-unused-const-variable  -Qunused-arguments  -c /usr/src/sbin/savecore/savecore.c -o savecore.o
cc -O2 -pipe -DWITH_CASPER -std=gnu99 -fstack-protector-strong -Wsystem-headers -Wall -Wno-format-y2k -W -Wno-unused-parameter -Wstrict-prototypes -Wmissing-prototypes -Wpointer-arith -Wreturn-type -Wcast-qual -Wwrite-strings -Wswitch -Wshadow -Wunused-parameter -Wcast-align -Wchar-subscripts -Winline -Wnested-externs -Wredundant-decls -Wold-style-definition -Wno-pointer-sign -Wmissing-variable-declarations -Wthread-safety -Wno-empty-body -Wno-string-plus-int -Wno-unused-const-variable -Qunused-arguments  -static  -o savecore savecore.o  -L/usr/obj/usr/src/amd64.amd64/lib/libxo -lxo -L/usr/obj/usr/src/amd64.amd64/lib/libutil -lutil -L/usr/obj/usr/src/amd64.amd64/lib/libz -lz -L/usr/obj/usr/src/amd64.amd64/lib/libcasper/libcasper -lcasper -L/usr/obj/usr/src/amd64.amd64/lib/libnv -lnv -L/usr/obj/usr/src/amd64.amd64/lib/libcap_fileargs -lcap_fileargs -L/usr/obj/usr/src/amd64.amd64/lib/libnv -lnv -L/usr/obj/usr/src/amd64.amd64/lib/libcasper/services/cap_syslog -lcap_syslog -L/usr/obj/usr/src/amd64.amd64/lib/libnv -lnv
ld: error: unable to find library -lcasper
ld: error: unable to find library -lcap_fileargs
ld: error: unable to find library -lcap_syslog
cc: error: linker command failed with exit code 1 (use -v to see invocation)
*** Error code 1

Stop.
make: stopped in /usr/src/sbin/savecore

The recent change r342699 breaks static link:

.include <src.opts.mk>
	 	 
	 	 .if ${MK_CASPER} != "no" && !defined(RESCUE)
	 	 CFLAGS+=        -DWITH_CASPER
	 	 LIBADD+=        casper cap_fileargs cap_syslog
	 	 .endif


I think something like this is needed to when defining WITHOUT_DYNAMICROOT:

.include <src.opts.mk>

.if ${MK_CASPER} != "no" && !defined(RESCUE) && !defined(WITHOUT_DYNAMICROOT)
CFLAGS+=	-DWITH_CASPER
LIBADD+=	casper cap_fileargs cap_syslog
.endif

Manfred
Received on Fri Jan 04 2019 - 18:15:00 UTC

This archive was generated by hypermail 2.4.0 : Wed May 19 2021 - 11:41:19 UTC