Re: sbin/camcontrol/camcontrol.c error breaks buildworld

On Tue, Jul 16, 2019 at 5:04 AM Dennis Clarke <dclarke_at_blastwave.org> wrote:

> On 7/16/19 6:55 AM, Dimitry Andric wrote:
> > On 16 Jul 2019, at 12:36, Dennis Clarke <dclarke_at_blastwave.org> wrote:
> >>
> >> On 7/16/19 2:48 AM, Warner Losh wrote:
> >>> On Tue, Jul 16, 2019 at 12:07 AM Dennis Clarke <dclarke_at_blastwave.org>
> >>> wrote:
> >>>> /usr/src/r350018/sbin/camcontrol/camcontrol.c: In function
> 'getdevtype':
> >>>> /usr/src/r350018/sbin/camcontrol/camcontrol.c:679: warning: comparison
> >>>> of unsigned expression < 0 is always false
> >>>>
> >>>> Anyone else seeing this ?
> >>>>
> >>> Fixed hours ago in 350020.
> >>
> >> Hours ago. Cool. However is there no CI testing on ppc64?
> >
> > There is a CI build, in any case:
> > https://ci.freebsd.org/job/FreeBSD-head-powerpc64-build/
> >
> > It showed a failure for build #11532 (r350018):
> > https://ci.freebsd.org/job/FreeBSD-head-powerpc64-build/11532/
> >
> > and also how it got fixed in build #11533 (r350020):
> > https://ci.freebsd.org/job/FreeBSD-head-powerpc64-build/11533/
> >
> > Unfortunately there is no test job which attempts to fire up a world
> > inside e.g. qemu.
>
> Oh well, thank you for the info.  Lucky me that I fell into the exact
> same build problem which only happens rarely. Hardly a lottery ticket
> win but I am happy to see the CI information.
>

The window would have been smaller. CI detected the breakage within 10
minutes, but I was away from my email attending to some household things
for an hour more...

Warner