Re: [package - head-i386-default][sysutils/lsof] Failed for lsof-4.93.2_2,8 in build

On Thu, Jul 25, 2019 at 12:13 PM Larry Rosenman <ler_at_freebsd.org> wrote:
>
> On 07/25/2019 1:10 pm, Alan Somers wrote:
> > On Thu, Jul 25, 2019 at 12:05 PM Larry Rosenman <ler_at_freebsd.org>
> > wrote:
> >>
> >> Um....  Who broke this?
> >>
> >> /usr/src/sys/sys/refcount.h:65:12: error: use of undeclared identifier
> >> 'false'
> >>                          return (false);
> >>                                  ^
> >> /usr/src/sys/sys/refcount.h:68:12: error: use of undeclared identifier
> >> 'true'
> >>                          return (true);
> >>                                  ^
> >> /usr/src/sys/sys/refcount.h:81:11: error: use of undeclared identifier
> >> 'false'
> >>                  return (false);
> >>                          ^
> >> /usr/src/sys/sys/refcount.h:90:10: error: use of undeclared identifier
> >> 'true'
> >>          return (true);
> >>                  ^
> >> /usr/src/sys/sys/refcount.h:106:12: error: use of undeclared
> >> identifier
> >> 'false'
> >>                          return (false);
> >>                                  ^
> >> /usr/src/sys/sys/refcount.h:108:12: error: use of undeclared
> >> identifier
> >> 'true'
> >>                          return (true);
> >>                                  ^
> >> /usr/src/sys/sys/refcount.h:121:12: error: use of undeclared
> >> identifier
> >> 'false'
> >>                          return (false);
> >>                                  ^
> >> /usr/src/sys/sys/refcount.h:123:12: error: use of undeclared
> >> identifier
> >> 'true'
> >>                          return (true);
> >>                                  ^
> >> 8 errors generated.
> >> *** Error code 1
> >>
> >> Stop.
> >> make[2]: stopped in
> >> /wrkdirs/usr/ports/sysutils/lsof/work/lsof-4.93.2/lib
> >> *** Error code 1
> >>
> >> Stop.
> >> make[1]: stopped in /wrkdirs/usr/ports/sysutils/lsof/work/lsof-4.93.2
> >> *** Error code 1
> >>
> >> Stop.
> >> make: stopped in /usr/ports/sysutils/lsof
> >>
> >> --
> >> Larry Rosenman                     http://people.freebsd.org/~ler
> >> Phone: +1 214-642-9640                 E-Mail: ler_at_FreeBSD.org
> >> US Mail: 5708 Sabbia Dr, Round Rock, TX 78665-2106
> >> _______________________________________________
> >> freebsd-current_at_freebsd.org mailing list
> >> https://lists.freebsd.org/mailman/listinfo/freebsd-current
> >> To unsubscribe, send any mail to
> >> "freebsd-current-unsubscribe_at_freebsd.org"
> >
> >
> > "svn blame" suggests r350199 by kib.  However, refcount.h should only
> > be included if lsof defines _KERNEL, which normal programs shouldn't.
> > So I think this should be considered a bug in lsof.
> > -Alan
>
>
> we *HAVE* to define _KERNEL, to get at the kernel structures.....

Then I think you have to live with this amount of instability.
refcount(9) says that you should include <sys/param.h>.  Did you do
that?  If so, then this is a man page bug and refcount(9) should also
specify stdbool.h.
-Alan