On 07/25/2019 1:40 pm, Justin Hibbits wrote: > On Thu, 25 Jul 2019 12:35:32 -0600 > Alan Somers <asomers_at_freebsd.org> wrote: > >> On Thu, Jul 25, 2019 at 12:13 PM Larry Rosenman <ler_at_freebsd.org> >> wrote: >> > >> > On 07/25/2019 1:10 pm, Alan Somers wrote: >> > > On Thu, Jul 25, 2019 at 12:05 PM Larry Rosenman <ler_at_freebsd.org> >> > > wrote: >> > >> >> > >> Um.... Who broke this? > ... >> > > "svn blame" suggests r350199 by kib. However, refcount.h should >> > > only be included if lsof defines _KERNEL, which normal programs >> > > shouldn't. So I think this should be considered a bug in lsof. >> > > -Alan >> > >> > >> > we *HAVE* to define _KERNEL, to get at the kernel structures..... >> >> Then I think you have to live with this amount of instability. >> refcount(9) says that you should include <sys/param.h>. Did you do >> that? If so, then this is a man page bug and refcount(9) should also >> specify stdbool.h. >> -Alan > > <sys/param.h> includes <sys/types.h> already, which typedefs bool. So > <sys/param.h> should suffice to include in lsof. > > - Justin > _______________________________________________ > freebsd-current_at_freebsd.org mailing list > https://lists.freebsd.org/mailman/listinfo/freebsd-current > To unsubscribe, send any mail to > "freebsd-current-unsubscribe_at_freebsd.org" Thanks all! I've got a PR into the lsof repo, and I'll fix it there. If we can't get a release out in the next day or 2, I'll patch it in the port. https://github.com/lsof-org/lsof/pull/70 -- Larry Rosenman http://people.freebsd.org/~ler Phone: +1 214-642-9640 E-Mail: ler_at_FreeBSD.org US Mail: 5708 Sabbia Dr, Round Rock, TX 78665-2106Received on Thu Jul 25 2019 - 17:10:47 UTC
This archive was generated by hypermail 2.4.0 : Wed May 19 2021 - 11:41:21 UTC