Re: make packages broken

On Mon, Jun 3, 2019 at 10:40 AM Andreas Nilsson <andrnils_at_gmail.com> wrote:

> Hello all,
>
> It was time for the weekly update so git gave
> me: c7cdb4a80779a0451dc2c04c3d6b30769049d402 .
>
> It compiled fined, but when I tried to build packages I get:
> make -C /usr/src PKG_VERSION=13.0.s20190603083918 real-packages
> make[5]: "/usr/obj/usr/src/amd64.amd64/toolchain-metadata.mk" line 1:
> Using cached toolchain metadata from build at charlotte.resilans.se on
> Mon Jun  3 10:12:27 CEST 2019
> --------------------------------------------------------------
> >>> Install check world
> --------------------------------------------------------------
> mkdir -p /tmp/install.M2Q9GbT8
> progs=$(for prog in [ awk cap_mkdb cat chflags chmod chown cmp cp  date
> echo egrep find grep id install   ln make mkdir mtree mv pwd_mkdb  rm sed
> services_mkdb sh sort strip sysctl test true uname wc zic tzsetup
> makewhatis; do  if progpath=`which $prog`; then  echo $progpath;  else
>  echo "Required tool $prog not found in PATH." >&2;  exit 1;  fi;  done);
>  libs=$(ldd -f "%o %p\n" -f "%o %p\n" $progs 2>/dev/null | sort -u |  while
> read line; do  set -- $line;  if [ "$2 $3" != "not found" ]; then  echo $2;
>  else  echo "Required library $1 not found." >&2;  exit 1;  fi;  done);  cp
> $libs $progs /tmp/install.M2Q9GbT8
> cp -R ${PATH_LOCALE:-"/usr/share/locale"} /tmp/install.M2Q9GbT8/locale
> mkdir -p /usr/obj/usr/src/amd64.amd64/worldstage/
> echo "#mtree 2.0" > /usr/obj/usr/src/amd64.amd64/worldstage//METALOG
> cd /usr/src; MACHINE_ARCH=amd64  MACHINE=amd64  CPUTYPE=skylake CC="cc
> -target x86_64-unknown-freebsd13.0
> --sysroot=/usr/obj/usr/src/amd64.amd64/tmp
> -B/usr/obj/usr/src/amd64.amd64/tmp/usr/bin" CXX="c++  -target
> x86_64-unknown-freebsd13.0 --sysroot=/usr/obj/usr/src/amd64.amd64/tmp
> -B/usr/obj/usr/src/amd64.amd64/tmp/usr/bin"  CPP="cpp -target
> x86_64-unknown-freebsd13.0 --sysroot=/usr/obj/usr/src/amd64.amd64/tmp
> -B/usr/obj/usr/src/amd64.amd64/tmp/usr/bin"  AS="as" AR="ar" LD="ld"
> LLVM_LINK=""  NM=nm OBJCOPY="objcopy"  RANLIB=ranlib STRINGS=  SIZE="size"
> PATH=/usr/obj/usr/src/amd64.amd64/tmp/usr/sbin:/usr/obj/usr/src/amd64.amd64/tmp/usr/bin:/usr/obj/usr/src/amd64.amd64/tmp/legacy/usr/sbin:/usr/obj/usr/src/amd64.amd64/tmp/legacy/usr/bin:/usr/obj/usr/src/amd64.amd64/tmp/legacy/bin::/tmp/install.M2Q9GbT8
>  LD_LIBRARY_PATH=/tmp/install.M2Q9GbT8
>  PATH_LOCALE=/tmp/install.M2Q9GbT8/locale make -f Makefile.inc1
>  INSTALL="install -U -M /usr/obj/usr/src/amd64.amd64/worldstage//METALOG -D
> /usr/obj/usr/src/amd64.amd64/worldstage" MTREE_CMD=" -W"
> __MAKE_SHELL=/tmp/install.M2Q9GbT8/sh -DNO_ROOT
> METALOG=/usr/obj/usr/src/amd64.amd64/worldstage//METALOG restage;
>  MACHINE_ARCH=amd64  MACHINE=amd64  CPUTYPE=skylake CC="cc -target
> x86_64-unknown-freebsd13.0 --sysroot=/usr/obj/usr/src/amd64.amd64/tmp
> -B/usr/obj/usr/src/amd64.amd64/tmp/usr/bin" CXX="c++  -target
> x86_64-unknown-freebsd13.0 --sysroot=/usr/obj/usr/src/amd64.amd64/tmp
> -B/usr/obj/usr/src/amd64.amd64/tmp/usr/bin"  CPP="cpp -target
> x86_64-unknown-freebsd13.0 --sysroot=/usr/obj/usr/src/amd64.amd64/tmp
> -B/usr/obj/usr/src/amd64.amd64/tmp/usr/bin"  AS="as" AR="ar" LD="ld"
> LLVM_LINK=""  NM=nm OBJCOPY="objcopy"  RANLIB=ranlib STRINGS=  SIZE="size"
> PATH=/usr/obj/usr/src/amd64.amd64/tmp/usr/sbin:/usr/obj/usr/src/amd64.amd64/tmp/usr/bin:/usr/obj/usr/src/amd64.amd64/tmp/legacy/usr/sbin:/usr/obj/usr/src/amd64.amd64/tmp/legacy/usr/bin:/usr/obj/usr/src/amd64.amd64/tmp/legacy/bin::/tmp/install.M2Q9GbT8
>  LD_LIBRARY_PATH=/tmp/install.M2Q9GbT8
>  PATH_LOCALE=/tmp/install.M2Q9GbT8/locale rm -rf /tmp/install.M2Q9GbT8
> --------------------------------------------------------------
> >>> Making hierarchy
> --------------------------------------------------------------
> cd /usr/src; make -f Makefile.inc1  LOCAL_MTREE= hierarchy
> cd /usr/src/etc;
> PATH=/usr/obj/usr/src/amd64.amd64/tmp/usr/sbin:/usr/obj/usr/src/amd64.amd64/tmp/usr/bin:/usr/obj/usr/src/amd64.amd64/tmp/legacy/usr/sbin:/usr/obj/usr/src/amd64.amd64/tmp/legacy/usr/bin:/usr/obj/usr/src/amd64.amd64/tmp/legacy/bin::/usr/obj/usr/src/amd64.amd64/tmp/usr/sbin:/usr/obj/usr/src/amd64.amd64/tmp/usr/bin:/usr/obj/usr/src/amd64.amd64/tmp/legacy/usr/sbin:/usr/obj/usr/src/amd64.amd64/tmp/legacy/usr/bin:/usr/obj/usr/src/amd64.amd64/tmp/legacy/bin::/tmp/install.M2Q9GbT8
> make LOCAL_MTREE=
> PATH=/usr/obj/usr/src/amd64.amd64/tmp/usr/sbin:/usr/obj/usr/src/amd64.amd64/tmp/usr/bin:/usr/obj/usr/src/amd64.amd64/tmp/legacy/usr/sbin:/usr/obj/usr/src/amd64.amd64/tmp/legacy/usr/bin:/usr/obj/usr/src/amd64.amd64/tmp/legacy/bin::/usr/obj/usr/src/amd64.amd64/tmp/usr/sbin:/usr/obj/usr/src/amd64.amd64/tmp/usr/bin:/usr/obj/usr/src/amd64.amd64/tmp/legacy/usr/sbin:/usr/obj/usr/src/amd64.amd64/tmp/legacy/usr/bin:/usr/obj/usr/src/amd64.amd64/tmp/legacy/bin::/tmp/install.M2Q9GbT8
> METALOG=/usr/obj/usr/src/amd64.amd64/worldstage//METALOG -DNO_ROOT
> distrib-dirs
> for file in /usr/share/doc/usd/10.exref /usr/share/doc/usd/11.edit
> /usr/share/doc/usd/12.vi /usr/share/doc/usd/13.viref; do  if [ -f
> /usr/obj/usr/src/amd64.amd64/worldstage/${file} ]; then  rm -f
> /usr/obj/usr/src/amd64.amd64/worldstage/${file};  fi;  done
> -W -deU -i -f /usr/src/etc/mtree/BSD.root.dist -p
> /usr/obj/usr/src/amd64.amd64/worldstage/
> /tmp/install.M2Q9GbT8/sh: -W: not found
> *** Error code 127
>
>
> Anyone else seeing this?
>
> Best regards
> Andreas
>

I seems mtree-related as the following patch allows it to make packages.
$ git diff
diff --git a/Makefile.inc1 b/Makefile.inc1
index 6c77c8abdb8..60ac6493c95 100644
--- a/Makefile.inc1
+++ b/Makefile.inc1
_at__at_ -888,7 +888,7 _at__at_ INSTALLFLAGS+=      -h sha256
 .endif
 .if defined(DB_FROM_SRC) || defined(NO_ROOT)
 IMAKE_INSTALL= INSTALL="${INSTALL} ${INSTALLFLAGS}"
-IMAKE_MTREE=   MTREE_CMD="${MTREE_CMD} ${MTREEFLAGS}"
+IMAKE_MTREE=   MTREE_CMD="${MTREE} ${MTREEFLAGS}"
 .endif

MTREE_CMD seems to be defined in /usr/src/etc/Makefile, was it meant to be
used in /usr/src/Makefile.inc1?

Best regards
Andreas