Re: sys/modules/sdio broken in .svn_revision 348842 'opt_cam.h' not found

On Mon, Jun 17, 2019, 8:06 AM Cy Schubert <Cy.Schubert_at_cschubert.com> wrote:

> On June 17, 2019 3:55:45 AM PDT, "Bjoern A. Zeeb" <bz_at_FreeBSD.org> wrote:
> >On 17 Jun 2019, at 10:37, Mark Linimon wrote:
> >
> >> On Mon, Jun 17, 2019 at 11:41:03AM +0200, Julian H. Stacey wrote:
> >>> svn_revision 348842
> >> [ ...]
> >>> /usr/src/sys/modules/sdio/../../dev/sdio/sdiob.c:68:10: fatal error:
> >>>       'opt_cam.h' file not found
> >>> #include "opt_cam.h"
> >>>          ^~~~~~~~~~~
> >>> 1 error generated.
> >>
> >> This is extremely unlikely to be r348842.  I would investigate
> >r349025
> >> instead.  (Committer Cc:ed.)
> >
> >Almost, more likely me.  I just had a look.  I am not exactly sure how
> >to reproduce this?
> >
> >/bz
> >_______________________________________________
> >freebsd-current_at_freebsd.org mailing list
> >https://lists.freebsd.org/mailman/listinfo/freebsd-current
> >To unsubscribe, send any mail to
> >"freebsd-current-unsubscribe_at_freebsd.org"
>
> Could this be a possible race? I had an unrelated build failure on one of
> my machines, all with the same src tree. Simply restarting the failed
> buildworld resolved it. All my other machines had no such failure.
>

The thing I fixed wasn't a race per se, but just s missing dependency for
the stand alone build case. I fixed exactly the bug reported, and the
report came from a rev w/o my change. I think it is just that simple.

Warner

-- 
> Pardon the typos and autocorrect, small keyboard in use.
> Cheers,
> Cy Schubert <Cy.Schubert_at_cschubert.com>
> FreeBSD UNIX: <cy_at_FreeBSD.org> Web: http://www.FreeBSD.org
>
>         The need of the many outweighs the greed of the few.
> _______________________________________________
> freebsd-current_at_freebsd.org mailing list
> https://lists.freebsd.org/mailman/listinfo/freebsd-current
> To unsubscribe, send any mail to "freebsd-current-unsubscribe_at_freebsd.org"
>