Re: sys/modules/sdio broken in .svn_revision 348842 'opt_cam.h' not found

Hi, Reference:
> From:		Cy Schubert <Cy.Schubert_at_cschubert.com>
> Reply-to:	Cy Schubert <Cy.Schubert_at_cschubert.com>
> Date:		Mon, 17 Jun 2019 18:26:25 -0700

Cy Schubert wrote:
> Now that I'm back home, to reply inline re the yacc.h issue.
> 
> In message <201906180021.x5I0L2RK057837_at_fire.js.berklix.net>, "Julian 
> H. Stacey
> " writes:
> > "Julian H. Stacey" wrote:
> > > "Bjoern A. Zeeb" wrote:
> > > > On 17 Jun 2019, at 10:37, Mark Linimon wrote:
> > > > 
> > > > > On Mon, Jun 17, 2019 at 11:41:03AM +0200, Julian H. Stacey wrote:
> > > > >> svn_revision 348842
> > > > > [ ...]
> > > > >> /usr/src/sys/modules/sdio/../../dev/sdio/sdiob.c:68:10: fatal error:
> > > > >>       'opt_cam.h' file not found
> > > > >> #include "opt_cam.h"
> > > > >>          ^~~~~~~~~~~
> > > > >> 1 error generated.
> > > > >
> > > > > This is extremely unlikely to be r348842.  I would investigate r349025
> > > > > instead.  (Committer Cc:ed.)
> > > > 
> > > > Almost, more likely me.  I just had a look.  I am not exactly sure how 
> > > > to reproduce this?
> > > > 
> > > > /bz
> > > 
> > > If I can help let me know.
> > > My buildworld broke with 13.0-CURRENT 
> > > /usr/src .ctm_status src-cur 14077 .svn_revision 348842
> > > I'm now running make install, 
> > > & can then compare my root include & libs with with a set installed 
> > > using DESTDIR=
> >
> > I compiled, installed, compared.  
> >   BTW cd /usr/src; make delete  - only cleans libs & bins but does not
> >   clean other junk listed in ObsoleteFiles.inc not even with
> >   -DBATCH_DELETE_OLD_FILES or -DBATCH_DELETE_OLD_FILES=YES so manually purged
> > ,
> > I believe I have a clean system built from .ctm_status src-cur 14077
> > .svn_revision 348842 but /usr/src/sys/modules/sdio still fails,
> > so there was a commit of unbuildable code.
> >
> > cd /usr/src ; find . -name opt_cam.h	# tools/tools/vhba/opt_cam.h
> > cd /usr/include ; find . -name opt_cam.h	# nothing
> >
> >
> > > I have a 2nd slower current box also building to 14077, I will then
> > > take that on up to latest .ctm_status src-cur 14087 .svn_revision
> > > 349129 to see if problem clears.
> >
> > make buildworld blew on newer current, with a different bug:
> >
> > cc  -O2 -pipe -I/usr/src/usr.bin/mkesdb_static -I/usr/src/usr.bin/mkesdb_stat
> > ic/../mkesdb  -I/usr/src/usr.bin/mkesdb_static/../../lib/libc/iconv  -g -MD  
> > -MF.depend.lex.o -MTlex.o -std=gnu99  -Qunused-arguments   -I/usr/obj/usr/src
> > /amd64.amd64/tmp/legacy/usr/include -c lex.c -o lex.o
> > /usr/src/usr.bin/mkesdb/lex.l:46:10: fatal error: 'yacc.h' file not found
> > #include "yacc.h"
> >          ^~~~~~~~
> > 1 error generated.
> > *** Error code 1
> >
> > Stop.
> > make[3]: stopped in /usr/src/usr.bin/mkesdb_static
> 
> slippy$ ls /export/obj/opt/src/svn-current/amd64.amd64/usr.bin/mkesdb
> lex.c             mkesdb.1.gz       mkesdb.full.meta  yacc.o
> lex.c.meta        mkesdb.1.gz.meta  mkesdb.meta       yacc.o.meta
> lex.o             mkesdb.debug      yacc.c
> lex.o.meta        mkesdb.debug.meta yacc.c.meta
> mkesdb            mkesdb.full       yacc.h   <---- here it is
> slippy$ 
> 
> >
> > A double waste of CPU & human time & power in a hot office.
> > Commit bits used to be suspended for un-buildable code. I'll boot stable.
> 
> Calm down.

I am actually calm, thanks.
I just have no more time to waste looking at current other people break.

> This looks like a corrupted obj directory,

I started with buildworld which should zap obj/

>  corrupted src 
> tree,

Nope. Clean export, not customised.
Customised with own hacks is what I've wanted to do for weeks,
System wont build generic, hence not customised. Still generic

>  or user error

Always possible. Even likely at times :-)

>  to me and it doesn't matter right now anyway. rm 
> -rf /usr/obj or wherever you keep it and start afresh.

Well I will,  but not yet, as said Im sick of breaking current.
so slower host has been booted with stable, upgraded to latest src/ 
& a buildworld started.

The faster host is left generic current at my original reported svn
& ctm numbers, now with generic bins libs includes, in case anyone
wants to look at that sdio modules problem.

As before mentioned, I upgraded src/ to newr on another host to see
if sdio problem had been fixed, & hot another flakety current
problem.


> And, have you used any kind of UNIX or UNIX-like system to know that 
> yacc.h is output from yacc?

Yes, but I forget chaff I shouldn't need to remember ;-).  Not
actually needed to deal with YACC since about 1985 or so.  Oh &
once or twice since.

I have other own code I want to build on top of a stable FreeBSD,
& don't want to spend forever chasing & fixing broken iterations of
FreeBSD.  

I've been doing Unix since about 1977, but tired of other people
commiting bad code that wastes time having to figure what someone
broke.  Hence belief: If some with lack of discipline commits bad
code that breaks buildworld: they should take a week off, after
revoking the breaking commit.

Cheers,
Julian
-- 
Julian Stacey, Consultant Systems Engineer, BSD Linux Unix, Munich Aachen Kent
 Brexit ref. stole votes from 700,000 Brits in EU; 1.9 M young, more remainers
 had no vote; 1.3 M old mostly leavers died.  Advert lies paid by noses in the
 trough; some foreign funders fined. New referendum now! http://stolenvotes.uk