Re: Mount Root fails: r347007

On Thu, May 2, 2019 at 11:42 AM Kyle Evans <kevans_at_freebsd.org> wrote:
>
> On Thu, May 2, 2019 at 11:40 AM Larry Rosenman <ler_at_lerctr.org> wrote:
> >
> > On 05/02/2019 11:34 am, Larry Rosenman wrote:
> > > On 05/02/2019 11:10 am, Larry Rosenman wrote:
> > >> On 05/02/2019 10:58 am, Warner Losh wrote:
> > >>> On Thu, May 2, 2019 at 9:54 AM Larry Rosenman <ler_at_lerctr.org> wrote:
> > >>>
> > >>>> On 05/02/2019 9:41 am, Larry Rosenman wrote:
> > >>>> > On 05/02/2019 9:24 am, Warner Losh wrote:
> > >>>> >> On Thu, May 2, 2019 at 7:40 AM Larry Rosenman <ler_at_lerctr.org> wrote:
> > >>>> >>
> > >>>> >>> On 05/02/2019 8:29 am, Warner Losh wrote:
> > >>>> >>> > On Wed, May 1, 2019 at 10:04 PM Larry Rosenman <ler_at_lerctr.org>
> > >>>> wrote:
> > >>>> >>> >
> > >>>> >>> >> Upgraded from r346487 to r347007, and when I reboot, I get a
> > >>>> mountroot
> > >>>> >>> >> prompt.  If I answer it with the same BootFS I booted from
> > >>>> >>> >> (zfs:zroot/ROOT/r347007) it continues to boot, and run.
> > >>>> >>> >>
> > >>>> >>> >> Dmesg: https://www.lerctr.org/~ler/Boot-NoRoot.txt
> > >>>> >>> >>
> > >>>> >>> >> What else do we need?
> > >>>> >>> >>
> > >>>> >>> >> I did upgrade the EFI partitions, and the freebsd-boot partitions
> > >>>> >>> >> and that did *NOT* change anything.
> > >>>> >>> >>
> > >>>> >>> >> Ideas?
> > >>>> >>> >>
> > >>>> >>> >
> > >>>> >>> > BIOS or UEFI booting?
> > >>>> >>>
> > >>>> >>> UEFI boot.
> > >>>> >>>
> > >>>> >>
> > >>>> >> So no change to \efi\boot\bootx64.efi (or whatever you are booting?
> > >>>> >>
> > >>>> >> Can you get the output of 'show' in the boot loader?
> > >>>> >>
> > >>>> >> Also, is there a way you can try one or two of the versions in between
> > >>>> >> 346487 and 347007 to try to narrow the changes down a bit?
> > >>>> >>
> > >>>> >> Warner
> > >>>> >
> > >>>> > show output in 4 screenshots:
> > >>>> > https://www.lerctr.org/~ler/FreeBSD/NO-BOOT/
> > >>>> >
> > >>>> > What's the easiest way to try some of the other revisions?  And which
> > >>>> > would
> > >>>> > you suggest?  (I'm set up for meta-mode).
> > >>>> working with Kyle Evans on IRC, and backing /boot/loader.efi to
> > >>>> r346487
> > >>>> lets the system boot
> > >>>> normally.
> > >>>>
> > >>>
> > >>> OK. I noticed vfs.root.mountfrom wasn't set. Can you see if it's set
> > >>> in
> > >>> your successfully booted system with kenv?
> > >>>
> > >>
> > >> 2 things: r346675 still works, and vfs.root.mountfrom *IS* set.
> > > r346879 does *NOT* work.  Stepping back to r346759
> > r346759 *WORKS*.  So it's r346879 that breaks it.
> >
>
> Hi,
>
> Head back to -head and try applying [0] -- this block was accidentally
> reintroduced, and I wouldn't be surprised if the double-initialization
> has some weird side effect.
>
> [0] https://people.freebsd.org/~kevans/loader.diff

To round things off: this patch was confirmed working and committed as r347023.