Re: make delete-old: missing some files?

On Sun, Oct 27, 2019 at 07:40:36PM +0700, Alexey Dokuchaev wrote:
> On Thu, Oct 24, 2019 at 11:07:16AM -0700, John Baldwin wrote:
> > On 10/22/19 8:42 PM, Alexey Dokuchaev wrote:
> > > On Tue, Oct 22, 2019 at 04:34:53PM -0700, John Baldwin wrote:
> > >> ...
> > >> These are from the OpenSSL 1.1.1 commit.  However, they are tagged as
> > >> OLD_LIBS and check-old-libs and delete-old-libs should be automatically
> > >> deleting these?  Does 'make check-old' report these files as
> > >> old libraries?
> > > 
> > > I've manually placed one of those back on the filesystem and `make
> > > check-old' reported it (twice!) under libraries.  But after r353907 it
> > > get cleaned up properly with `make delete-old'.
> > 
> > Hmm, then 'make delete-old-libs' should already delete them without needing
> > r353907.  The issue with r353907 is if someone doesn't delete the
> > actual libraries via 'make delete-old-libs' but then tries to debug an
> > application that was using the old openssl and crashed, we'd no longer
> > have debug symbols if the crash was in one of those libraries.  That
> > matters less for OpenSSL engines, but matters more for something like
> > libutil, etc. hence why we delete debug symbols as part of delete-old-libs
> > instead of delete-old.
> > 
> > If 'make delete-old-libs' deletes these files already, then we should
> > probably revert r353907.
> 
> I've reverted r353907, and `make delete-old-libs' deleted those files.

So what was the final decision, did you guys sort it out?  I've seen that
r353907 was MFC'ed while it was still being discussed, hence my question:
https://svnweb.freebsd.org/base?view=revision&revision=354150.

> Also, I've noticed that `lib/libdtrace.so.2' is listed twice in the
> tools/build/mk/OptionalObsoleteFiles.inc, which is probably another bug.

What about DTrace-related issues (this and the previous one)?

./danfe