Re: head r355027 fails to (non-debug) build for: sys/arm/broadcom/bcm2835/bcm2835_sdhci.c:721:26: error: unused variable 'sc

From: Kyle Evans <kevans_at_freebsd.org> Date: Sat, 23 Nov 2019 07:41:21 -0600 · This archive was generated by hypermail 2.4.0 : Wed May 19 2021 - 11:41:22 UTC

On Sat, Nov 23, 2019 at 2:42 AM Mark Millard <marklmi_at_yahoo.com> wrote:
>
> --- bcm2835_sdhci.o ---
> /usr/src/sys/arm/broadcom/bcm2835/bcm2835_sdhci.c:721:26: error: unused variable 'sc' [-Werror,-Wunused-variable]
>         struct bcm_sdhci_softc *sc = device_get_softc(slot->bus);
>                                 ^
> 1 error generated.
>
> This is because the sc is only used in:
>
>         KASSERT(sc->dmamap_seg_count == 0,
>             ("data pending interrupt pushed through SDHCI framework"));
>
> and this was a non-debug build: so the KASSERT did not use sc either.
>
>

Whoops, sorry about that! Fixed in r355031.

Thanks,

Kyle Evans