On Fri, 24 Apr 2020 at 07:23, Fabian Keil <freebsd-listen_at_fabiankeil.de> wrote: > > > I wonder if we could drop the sort and replace ${TZS} in line 100 with > > ${TZS:O} instead? > > Makes sense to me. Agreed, that seems sensible. > > By the way, looking at > > https://github.com/freebsd/pkg/blob/master/libpkg/metalog.c , I wonder if > > the sort should really happen in pkg(8) instead? > > Currently the METALOG is also used when creating the tarballs so sorting > only in pkg would be insufficient as long as tarballs are still supported. I think there are other reasons we'd like to keep METALOG itself in deterministic order too, even if pkg can take care of it -- for example, issues like PR234886 can be triggered by ordering (even though the root cause is elsewhere and TZ ordering isn't going to lead to exactly that kind of issue).Received on Fri Apr 24 2020 - 17:23:32 UTC
This archive was generated by hypermail 2.4.0 : Wed May 19 2021 - 11:41:23 UTC