Re: panic: Assertion in_epoch(net_epoch_preempt) failed, r357793

On Wed, Feb 12, 2020 at 09:18:32AM -0800, Gleb Smirnoff wrote:
T> On Wed, Feb 12, 2020 at 07:41:54PM +0300, yp_at_mm.st wrote:
T> y> Gleb Smirnoff wrote:
T> y> > On Wed, Feb 12, 2020 at 09:49:12AM +0300, yp_at_mm.st wrote:
T> y> > y> Getting the following panic after updating to r357793 (expect typos, hand
T> y> > y> copied):
T> y> > y>
T> y> > y> panic: Assertion in_epoch(net_epoch_preempt) failed at
T> y> > y> /usr/src/sys/net/iflib.c:2762
T> y> > y>
T> y> > y> db_trace_self_wrapper()
T> y> > y> vpanic()
T> y> > y> panic()
T> y> > y> iflib_rxeof()
T> y> > y> _task_fn_rx()
T> y> > y> gtaskqueue_run_locked()
T> y> > y> gtaskqueue_thread_loop()
T> y> > y> fork_exit()
T> y> > y> fork_trampoline()
T> y> > y> --- trap 0, rip = 0, rsp = 0, rbp = 0 ---
T> y> > 
T> y> > Are you running iflib as a loadable module? Your trace clearly
T> y> > has _task_fn_rx(), and Hans's patch covers _task_fn_tx(). However,
T> y> > Hans's patch helped you. So, my guess is happen just due to
T> y> > recompilation and reinstall of the module, not due to patch.
T> y> 
T> y> No, it was a clean install from latest snapshot ISO, updated to that
T> y> revision using the usual {build,install}{world,kernel} procedure without
T> y> any settings in src.conf and using GENERIC conf, so iflib is builtin.
T> 
T> Sorry, Hans's patch is correct. I didn't notice the alternative
T> initializer of taskqueue. Strange that this didn't pop up with
T> my igb0. Will fix in few minutes.

Hans already checked in his patch. Great!

-- 
Gleb Smirnoff