Re: FreeBSD-head-amd64-test - Build #13912 (r356671) - Failure

On Mon, Jan 13, 2020 at 1:10 PM <jenkins-admin_at_freebsd.org> wrote:
>
> FreeBSD-head-amd64-test - Build #13912 (r356671) - Failure
>
> Build information: https://ci.freebsd.org/job/FreeBSD-head-amd64-test/13912/
> Full change log: https://ci.freebsd.org/job/FreeBSD-head-amd64-test/13912/changes
> Full build log: https://ci.freebsd.org/job/FreeBSD-head-amd64-test/13912/console
>
> Status explanation:
> "Failure" - the build is suspected being broken by the following changes
> "Still Failing" - the build has not been fixed by the following changes and
>                   this is a notification to note that these changes have
>                   not been fully tested by the CI system
>
> Change summaries:
> (Those commits are likely but not certainly responsible)
>
> 356671 by mjg:
> ufs: use lazy list instead of active list for syncer
>
> Quota code is temporarily regressed to do a full vnode scan.
>
> Reviewed by:    jeff
> Tested by:      pho (in a larger patch, previous version)
> Differential Revision:  https://reviews.freebsd.org/D22996
>
> 356670 by mjg:
> vfs: add per-mount vnode lazy list and use it for deferred inactive + msync
>
> This obviates the need to scan the entire active list looking for vnodes
> of interest.
>
> msync is handled by adding all vnodes with write count to the lazy list.
>
> deferred inactive directly adds vnodes as it sets the VI_DEFINACT flag.
>
> Vnodes get dequeued from the list when their hold count reaches 0.
>
> Newly added MNT_VNODE_FOREACH_LAZY* macros support filtering so that
> spurious locking is avoided in the common case.
>
> Reviewed by:    jeff
> Tested by:      pho (in a larger patch, previous version)
> Differential Revision:  https://reviews.freebsd.org/D22995
>
> 356669 by mjg:
> ufs: add a setter for inode i_flag field
>
> This will be used later to add vnodes to the lazy list.
>
> Reviewed by:    kib (previous version), jeff
> Tested by:      pho (in a larger patch)
> Differential Revision:  https://reviews.freebsd.org/D22994

Hi Mateusz,

I suspect these changes might have something to do about panic of i386
and amd64 in testing:

root_at_:/usr/tests # cd /usr/tests/usr.sbin/makefs/
root_at_:/usr/tests/usr.sbin/makefs # kyua debug
makefs_cd9660_tests:o_flag_rockridge_dev_nodes
VNASSERT failed
0xfffff8000f24a1e8: type VCHR
    usecount 1, writecount 0, refcount 1 rdev 0
    flags ()
 VI_LOCKed    lock type ufs: SHARED (count 1)
        nlink=1, effnlink=1, size=0, extsize 0
        generation=73c32c64, uid=0, gid=0, flags=0x0
        ino 117778, on dev gpt/rootfs
panic: ffs_unlock_debug: modified vnode (420) not on lazy list
cpuid = 1
time = 1578910603
KDB: stack backtrace:
db_trace_self_wrapper() at db_trace_self_wrapper+0x2b/frame 0xfffffe0038a70fd0
vpanic() at vpanic+0x185/frame 0xfffffe0038a71030
panic() at panic+0x43/frame 0xfffffe0038a71090
ffs_unlock_debug() at ffs_unlock_debug+0xa5/frame 0xfffffe0038a710c0
lookup() at lookup+0xd26/frame 0xfffffe0038a71160
namei() at namei+0x4d8/frame 0xfffffe0038a71250
kern_fchmodat() at kern_fchmodat+0x92/frame 0xfffffe0038a71380
amd64_syscall() at amd64_syscall+0x2d6/frame 0xfffffe0038a714b0
fast_syscall_common() at fast_syscall_common+0x101/frame 0xfffffe0038a714b0
--- syscall (15, FreeBSD ELF64, sys_chmod), rip = 0x8003ba95a, rsp =
0x7fffffffe758, rbp = 0x7fffffffe7e0 ---
KDB: enter: panic
[ thread pid 1393 tid 100092 ]
Stopped at      kdb_enter+0x37: movq    $0,0x1084396(%rip)
db:0:kdb.enter.panic> show pcpu
cpuid        = 1
dynamic pcpu = 0xfffffe00887a7d80
curthread    = 0xfffff8000f25a000: pid 1393 tid 100092 critnest 1 "bsdtar"
curpcb       = 0xfffff8000f25a4f0
fpcurthread  = 0xfffff8000f25a000: pid 1393 "bsdtar"
idlethread   = 0xfffff800033976e0: tid 100004 "idle: cpu1"
self         = 0xffffffff82211000
curpmap      = 0xfffff80003e35120
tssp         = 0xffffffff82211384
rsp0         = 0xfffffe0038a71580
kcr3         = 0x800000000f2ab405
ucr3         = 0x800000000f287c05
scr3         = 0xf287c05
gs32p        = 0xffffffff82211404
ldt          = 0xffffffff82211444
tss          = 0xffffffff82211434
tlb gen      = 889
curvnet      = 0
spin locks held:
db:0:kdb.enter.panic>

full log:
https://ci.freebsd.org/job/FreeBSD-head-i386-test/8051/consoleFull
https://ci.freebsd.org/job/FreeBSD-head-amd64-test/13912/consoleFull

test image:
https://artifact.ci.freebsd.org/snapshot/head/r356671/i386/i386/disk-test.img.xz
https://artifact.ci.freebsd.org/snapshot/head/r356671/amd64/amd64/disk-test.img.xz

Can you help check this? Thanks.

Best,
Li-Wen