Re: svn commit: r363031 - in head: contrib/bmake contrib/bmake/lst.lib contrib/bmake/mk contrib/bmake/mk/sys contrib/bmake/unit-tests usr.bin/bmake (make now broken)

Mark Millard wrote:
> This seems to have broken doing buildworld buildkernel and
> other things using make:
> 
> make[2]: "/usr/src/share/mk/bsd.compiler.mk" line 197: warning: String comparison operator should be either == or !=
> make[2]: "/usr/src/share/mk/bsd.compiler.mk" line 197: warning: String comparison operator should be either == or !=
> . . .
> make[3]: "/usr/src/share/mk/bsd.sys.mk" line 100: warning: String comparison operator should be either == or !=
> . . .
> make[3]: "/usr/src/share/mk/bsd.sys.mk" line 81: warning: String comparison operator should be either == or !=
> . . .
> 
> Using -d c shows the likes of:
> 
> . . .
> lhs = "clang", rhs = "clang", op = ==
> lhs = "${${:UCOMPILER_TYPE}__${${:U${_empty_var_}}_cc_hash}}", rhs = "gcc", op = ==
> make[2]: "/usr/src/share/mk/bsd.compiler.mk" line 197: warning: String comparison operator should be either == or !=
> lhs = "clang", rhs = "clang", op = ==
> lhs = "LD", rhs = "LD", op = ==
> . . .
> left = 6.000000, right = 2.000000, op = <=
> left = 6.000000, right = 1.000000, op = <=
> lhs = "${${:UCOMPILER_TYPE}__${${:U${_empty_var_}}_cc_hash}}", rhs = "clang", op = ==
> make[3]: "/usr/src/share/mk/bsd.sys.mk" line 100: warning: String comparison operator should be either == or !=
> lhs = "${${:UCOMPILER_TYPE}__${${:U${_empty_var_}}_cc_hash}}", rhs = "gcc", op = ==
> lhs = "clang", rhs = "gcc", op = ==
> . . .
> left = 0.000000, right = 6.000000, op = <=
> left = 0.000000, right = 3.000000, op = <=
> lhs = "clang", rhs = "gcc", op = ==
> make[3]: "/usr/src/share/mk/bsd.sys.mk" line 81: warning: String comparison operator should be either == or !=
> lhs = "clang", rhs = "clang", op = ==
> left = 100001.000000, right = 70000.000000, op = >=
> lhs = "amd64", rhs = "arm", op = ==
> 
> (Now I just need to figure out how to get back to a working context.)

For me, buildworld/buildkernel produced only warnings, though the one in 
ports is real issue:

$ make config
make: "/usr/ports/Mk/bsd.port.mk" line 2096: warning: String comparison 
operator should be either == or !=
make: "/usr/ports/Mk/bsd.port.mk" line 2096: Malformed conditional 
(defined(MAKE_JOBS_NUMBER_LIMIT) && ( ${MAKE_JOBS_NUMBER_LIMIT} < 
${_MAKE_JOBS_NUMBER} ))
make: Fatal errors encountered -- cannot continue
make: stopped in /usr/ports/devel/subversion