Re: vfs_mouse.c breakage?

It also needed <rpc/types.h>.
It is ancient code (that started out in SunOS. if I recall correctly), where they
used things like "bool_t" and set them with TRUE/FALSE (upper case).

Unfortunately, those includes love to include other includes...

Anyhow, I think it is fixed now, rick

________________________________________
From: Pete Wright <pete_at_nomadlogic.org>
Sent: Monday, June 1, 2020 8:05 PM
To: Rick Macklem; FreeBSD Current
Subject: Re: vfs_mouse.c breakage?

CAUTION: This email originated from outside of the University of Guelph. Do not click links or open attachments unless you recognize the sender and know the content is safe. If in doubt, forward suspicious emails to IThelp_at_uoguelph.ca



On 6/1/20 2:50 PM, Rick Macklem wrote:
> Pete Wright wrote:
>> Subject: vfs_mouse.c breakage?
> Not sure if the vfs mouse is broken (sorry, I couldn't resist), but...

hah nice - dyslexia + poor eyesight are not good bedfellows :^)
>
> I think it needs a:
> #include <rpc/auth.h>
>
> but it will take a little while for me to test this.
>
> Thanks for reporting it, rick

no prob - adding that include thew some more errors

$ git diff
diff --git a/sys/kern/vfs_mount.c b/sys/kern/vfs_mount.c
index 03f95b2845f9..4282b1938095 100644
--- a/sys/kern/vfs_mount.c
+++ b/sys/kern/vfs_mount.c
_at__at_ -39,6 +39,7 _at__at_
  #include <sys/cdefs.h>
  __FBSDID("$FreeBSD$");

+#include <rpc/auth.h>
  #include <sys/param.h>
  #include <sys/conf.h>
  #include <sys/smp.h>


here's a snippet of the exception:
--- vfs_mount.o ---
In file included from /usr/home/pete/git/freebsd/sys/kern/vfs_mount.c:42:
In file included from /usr/home/pete/git/freebsd/sys/rpc/auth.h:50:
/usr/home/pete/git/freebsd/sys/rpc/xdr.h:105:3: error: type name
requires a specifier or qualifier
                 bool_t  (*x_getlong)(struct XDR *, long *);


I'll sit tight for now - thanks for checking it out!

-pete

--
Pete Wright
pete_at_nomadlogic.org
_at_nomadlogicLA