John-Mark Gurney wrote this message on Thu, Nov 05, 2020 at 16:13 -0800: > I just discovered that we have a variable name colission between the > FreeBSD base repo, and the ports tree. DISTDIR is used by the ports > repo for: > # DISTDIR - Where to search for and store copies of original sources > > But DISTDIR is also used by FreeBSD base for (from bsd.own.mk): > # DISTDIR Change the tree where the file for a distribution > # gets installed (see /usr/src/release/Makefile). [not set] > > except that it doesn't just get used in release/Makefile, it's used in > the base Makefile.inc1 for a number of things that I'm not entirely sure > what it's for. > > Can someone figure out what we should do in this case? > > This was discovered because ezjail-admin sets DISTDIR for ports, but it > was breaking my -DNO_ROOT installworld by putting the METALOG in an > incorrectly documented place (since fixed)... It was pointed out that there was a review already underway for this: https://reviews.freebsd.org/D26617 Can this just be tested by re, and committed? Thanks. -- John-Mark Gurney Voice: +1 415 225 5579 "All that I will do, has been done, All that I have, has not."Received on Fri Nov 06 2020 - 00:08:33 UTC
This archive was generated by hypermail 2.4.0 : Wed May 19 2021 - 11:41:25 UTC