Re: update UPDATING after malloc code change

On Sat, 7 Nov 2020 19:24:02 -0700
Warner Losh <imp_at_bsdimp.com> wrote:

> On Sat, Nov 7, 2020 at 5:43 PM Tomoaki AOKI <junchoon_at_dec.sakura.ne.jp>
> wrote:
> 
> > On Sun, 8 Nov 2020 00:22:26 +0100
> > Guido Falsi <mad_at_madpilot.net> wrote:
> >
> > > On 07/11/20 17:20, Gary Jennejohn wrote:
> > > > It seems like an entry should be added to /usr/src/UPDATING, since the
> > change made
> > > > to the malloc code causes panics with KMODs from ports if they haven't
> > been
> > > > re-compiled.  My nvidia-driver also caused a panic with a new kernel.
> > > >
> > > > A reminder/warning would be useful.
> > > >
> > >
> > > Why? Rebuilding kmods every time you update the kernel sources is
> > > already required by default.
> >
> > IIRC, there's no official documentation for it.
> >
> 
> There is a warning to disable to old modules, which is close...
> 
> 
> > Adding new NOTE for it into UPDATING (before the first dated entry)
> > would be a good idea, as someone encounterd problem would read it
> > to confirm any cautions.
> >
> 
> https://svnweb.freebsd.org/base?view=revision&revision=367474 has my take
> on that. Please let me know what you think.

Thanks for taking this, Warner.

IMHO, persons reading UPDATING "after" causing boot issue would be
in panic, and if they use pagers like more, less, or lv and cannot find
helpful info at the top end of UPDATING, they would give up.

So adding something like "All kernel modules are needed to be rebuilt
when you update kernel. See note [1] in COMMON ITEMS section near
the end of this file for details." as a top-side NOTE would be helpful.

For [1] you updated at r367475, it would be better noting in what file
to add PORTS_MODULES entry (/etc/src.conf, normally).

Regards.


> Warner
> 
> 
> > > You should be surprised when the old kmods still work, not the other way
> > > around.
> >
> > +1.
> >
> > >
> > > --
> > > Guido Falsi <mad_at_madpilot.net>
> > > _______________________________________________
> > > freebsd-current_at_freebsd.org mailing list
> > > https://lists.freebsd.org/mailman/listinfo/freebsd-current
> > > To unsubscribe, send any mail to "
> > freebsd-current-unsubscribe_at_freebsd.org"
> >
> >
> > --
> > Tomoaki AOKI    <junchoon_at_dec.sakura.ne.jp>
> > _______________________________________________
> > freebsd-current_at_freebsd.org mailing list
> > https://lists.freebsd.org/mailman/listinfo/freebsd-current
> > To unsubscribe, send any mail to "freebsd-current-unsubscribe_at_freebsd.org"
> >
> _______________________________________________
> freebsd-current_at_freebsd.org mailing list
> https://lists.freebsd.org/mailman/listinfo/freebsd-current
> To unsubscribe, send any mail to "freebsd-current-unsubscribe_at_freebsd.org"


-- 
Tomoaki AOKI    <junchoon_at_dec.sakura.ne.jp>