Re: Problem with zfs.ko: lockstat_enabled symbol

On Sat, Sep 12, 2020 at 7:55 AM Mark Murray <markm_at_freebsd.org> wrote:
>
> On 12 Sep 2020, at 12:18, Eric McCorkle <eric_at_metricspace.net> wrote:
> >
> > I recently updated my other laptop, and now I'm getting a problem
> > loading zfs.ko at boot, relating to the lockstat_enabled symbol not
> > being defined (this happens during kernel boot and prevents mounting
> > root, so I can't get an exact trace)
> >
> > Looking at the new kernel, it seems that only zfs.ko contains the symbol
> > lockstat_enabled (notably, kernel does not).  In my old kernel, zfs.ko
> > does not contain a reference to that symbol.
> >
> > Has anyone else seen this?  Is there a workaround, or was this a one-off
> > bug?
>
> I had this, and I fixed it by adding
>
> options ZFS
>
> ... to my kernel config.
>
> I found this in a nearby NOTES file; perhaps it should be in GENERIC?
>

This looks like a header bug, and the above fixes it by just compiling
in ZFS so that the undefined symbol is not an issue. See the below
patch, which moves the extern declaration of lockstat_enabled under
KDTRACE_HOOKS (you must be missing this option). I haven't even build
tested:

diff --git a/sys/sys/lockstat.h b/sys/sys/lockstat.h
index 6a5f79a2f15..d42026f9b2d 100644
--- a/sys/sys/lockstat.h
+++ b/sys/sys/lockstat.h
_at__at_ -77,10 +77,10 _at__at_ SDT_PROBE_DECLARE(lockstat, , , thread__spin);
 #define        LOCKSTAT_WRITER         0
 #define        LOCKSTAT_READER         1

-extern volatile bool lockstat_enabled;
-
 #ifdef KDTRACE_HOOKS

+extern volatile bool lockstat_enabled;
+
 #define        LOCKSTAT_RECORD0(probe, lp)
                \
        SDT_PROBE1(lockstat, , , probe, lp)