Re: sys/sys/param.h: 'main' instead of 'Master'?

From: Warner Losh <imp_at_bsdimp.com>
Date: Mon, 19 Apr 2021 15:58:33 -0600
On Mon, Apr 19, 2021 at 7:12 AM Rodney W. Grimes <
freebsd-rwg_at_gndrsh.dnsmgr.net> wrote:

> > On Sun, Apr 18, 2021 at 07:07:44PM -0400, Ed Maste wrote:
> > > On Fri, 16 Apr 2021 at 16:22, Warner Losh <imp_at_bsdimp.com> wrote:
> > > >
> > > > > > As well as "Origin".
> > > > >
> > > > > (Single) Source of Truth, maybe?
> > > >
> > > > s/Master, p/P/ also makes sense.
> > >
> > > IMO instead of lightly rewording the existing comment we could just
> > > remove it, it doesn't really add any clarity.
> > >
> > > Instead we ought to add an introductory sentence or two to the block
> > > comment above, explaining what __FreeBSD_version actually is.
> >
> > fully agreed here! I had to explained many time what __FreeBSD_version
> actually
> > was. A clear comment would be great ;)
>
> Yes please!


Well, we explain the scheme w/o explaining when / why you'd want to bump it.

https://reviews.freebsd.org/D29850

has my attempt to do the latter. Please comment there...

Warner
Received on Mon Apr 19 2021 - 19:58:46 UTC

This archive was generated by hypermail 2.4.0 : Wed May 19 2021 - 11:41:28 UTC