Re: unused function errors in tcp_lro.c

On Wed, 17 Feb 2021 18:12:39 +0100
Gary Jennejohn <gljennjohn_at_gmail.com> wrote:

> Running buildkernel after 48e62e6561b..effe8b9cb31
> 
> --------------------------------------------------------------
> >>> stage 3.1: building everything  
> --------------------------------------------------------------
> /usr/src/sys/netinet/tcp_lro.c:1297:1: warning: unused function 'build_ack_entry' [-Wunused-function]
> build_ack_entry(struct tcp_ackent *ae, struct tcphdr *th, struct mbuf *m, uint16_t hdr_len, uint16_t iptos)
> ^
> /usr/src/sys/netinet/tcp_lro.c:1339:1: warning: unused function 'do_bpf_and_csum' [-Wunused-function]
> do_bpf_and_csum(struct inpcb *inp, struct lro_ctrl *lc, struct lro_entry *le,
> ^
> 2 warnings generated.
> 
> These function declarations should be gated using #ifdef TCPHPTS.
> 

Thanks for fixing this, but now afer 962a3814d4c..ab4fad4be14 I get

--------------------------------------------------------------
>>> stage 3.1: building everything
--------------------------------------------------------------
/usr/src/sys/netinet/tcp_lro.c:474:1: warning: unused function 'tcp_lro_log'
[-Wunused-function]
tcp_lro_log(struct tcpcb *tp, struct lro_ctrl *lc,
^
1 warning generated.

This function is also only used when TCPHPTS is defined.

-- 
Gary Jennejohn