Re: problem building virtualbox-ose-kmod

On 1/26/21 9:13 AM, Mark Millard via freebsd-current wrote:
> monochrome monochrome at twcny.rr.com wrote on
> Tue Jan 26 06:34:23 UTC 2021 :
> 
>> . . . for quite a while now, maybe over a month . . .
> 
>> --- memobj-r0drv-freebsd.o ---
>> /usr/ports/emulators/virtualbox-ose-kmod/work/VirtualBox-5.2.44/out/freebsd.amd64/release/bin/src/vboxdrv/r0drv/freebsd/memobj-r0drv-freebsd.c:887:80:
>> error: too few arguments to function call, expected 6, have 5
>>       int krc = vm_map_protect(pVmMap, AddrStart, AddrEnd,
>> ProtectionFlags, FALSE);
>>                 ~~~~~~~~~~~~~~
>>          ^
>> /usr/src/sys/vm/vm_map.h:517:5: note: 'vm_map_protect' declared here
>> int vm_map_protect(vm_map_t map, vm_offset_t start, vm_offset_t end,
>>       ^
>> 1 error generated.
>> *** [memobj-r0drv-freebsd.o] Error code 1
> 
> 
> The change from 5 parameters to 6 parameters is recent: main's 0659df6faddf
> as of 2021-01-12 23:35:22 +0000 (commit).  Its one line description is:
> 
> QUOTE
> vm_map_protect: allow to set prot and max_prot in one go
> END QUOTE
> 
> It added a "int flags" parameter.
> 
> https://bugs.freebsd.org/bugzilla/show_bug.cgi?id=252952 is about:
> 
> vm_map_protect manual page requires an update after 0659df6faddf . . .
> 
> (So if there was a problem about a month ago, there may be another
> problem as well as the above that was something else, the above just
> happens first now.)
> 
> Looks like emulators/virtualbox-ose-kmod needs to track the kernel
> change(s).
> 
See solution in https://bugs.freebsd.org/bugzilla/show_bug.cgi?id=252675

Henri