Re: fsck strange output

From: Kirk McKusick <mckusick_at_mckusick.com>
Date: Tue, 26 Jan 2021 12:01:39 -0800
> From: Rozhuk Ivan <rozhuk.im_at_gmail.com>
> Date: Tue, 26 Jan 2021 17:08:41 +0300
> To: Kirk McKusick <mckusick_at_mckusick.com>
> Cc: freebsd-current_at_freebsd.org
> Subject: Re: fsck strange output
> 
> On Mon, 25 Jan 2021 15:40:12 -0800
> Kirk McKusick <mckusick_at_mckusick.com> wrote:
> 
> 
>> Please try this patch to fsck_ffs and see if it fixes your problem.
>> 
>> 	Kirk McKusick
>> 
>> =-=-=
>> 
>> *** sbin/fsck_ffs/inode.c.orig	2021-01-07 15:04:04.969086284
>> -0800 --- sbin/fsck_ffs/inode.c	2021-01-25 15:29:06.404803358
>> -0800 ***************
>> *** 611,618 ****
>>   	    sizeof(struct ufs1_dinode) : sizeof(struct
>> ufs2_dinode)); readpercg = inosused / fullcnt;
>>   	partialcnt = inosused % fullcnt;
>> ! 	partialsize = partialcnt * ((sblock.fs_magic ==
>> FS_UFS1_MAGIC) ? ! 	    sizeof(struct ufs1_dinode) :
>> sizeof(struct ufs2_dinode)); if (partialcnt != 0) {
>>   		readpercg++;
>>   	} else {
>> --- 611,619 ----
>>   	    sizeof(struct ufs1_dinode) : sizeof(struct
>> ufs2_dinode)); readpercg = inosused / fullcnt;
>>   	partialcnt = inosused % fullcnt;
>> ! 	partialsize = fragroundup(&sblock,
>> ! 	    partialcnt * ((sblock.fs_magic == FS_UFS1_MAGIC) ?
>> ! 	    sizeof(struct ufs1_dinode) : sizeof(struct
>> ufs2_dinode))); if (partialcnt != 0) {
>>   		readpercg++;
>>   	} else {
> 
> 
> https://github.com/rozhuk-im/freebsd/commit/5e8bfa01830e2b6ecb88e572064c6fffe5a2df2d
> (if I apply correct :) )
> 
> With this patch - seems no errors, thanks!

Thanks for your testing. It has also corrected the same problem in
Peter Holm's test suite. So, I am committed it as 8c22cf9. I will
also ensure that it gets MFC'ed into 13.0.

	Kirk McKusick
Received on Tue Jan 26 2021 - 18:58:28 UTC

This archive was generated by hypermail 2.4.0 : Wed May 19 2021 - 11:41:27 UTC