Re: some small patches

From: Julian Elischer <julian_at_elischer.org>
Date: Fri, 18 Apr 2003 09:28:16 -0700 (PDT)
On Fri, 18 Apr 2003, Bruce Evans wrote:

> On Thu, 17 Apr 2003, Julian Elischer wrote:
> 
> > On Thu, 17 Apr 2003, Jeff Roberson wrote:
> >
> > > I object to the sched_clock() change.  We've discussed this on threads_at_
> >
> > Yes and the clock code doesn't need to know about KSEs and it is of
> > ABSOLUTLY NO difference to the sched_clock() function if it derives the
> > thread from the KSE or derives the KSE from the thread.
> 
> I mostly agree, but your argument would be better if statclock() didn't
> need to know about the KSE to determine the niceness.  The niceness

It doesn't, the patch also gets the niceness without going via the KSE.

the current code says:
ke->ke_ksegrp->kg_nice
the patched code says:
td->td_ksegrp->kg_nice

which gives the same thing.



> statistic is rotting anyway.  It only covers one type of special
> scheduling.  Statistics utilites generally are mostly missing support for
> the following complications:
> - rtprio/idprio scheduling
> - POSIX scheduling
> - KSE
> - alternative schedulers

yep.
That last one can be fixed easier in a running kernel, but
becomes very hard to fix with coredumps. (coredumps can't call methods).

> 
> Bruce
> 
Received on Fri Apr 18 2003 - 07:28:23 UTC

This archive was generated by hypermail 2.4.0 : Wed May 19 2021 - 11:37:04 UTC