Re: USB da(4) quirks deprecated

On Fri, 8 Aug 2003, Andrew Thompson wrote:
> On Fri, 2003-08-08 at 15:13, Nate Lawson wrote:
> > On Fri, 8 Aug 2003, Andrew Thompson wrote:
> > > da0 at umass-sim0 bus 0 target 0 lun 0
> > > da0: <SigmaTel MSCN 0001> Removable Direct Access SCSI-4 device
> > > da0: 1.000MB/s transfers
> > > da0: 125MB (256001 512 byte sectors: 64H 32S/T 125C)
> >
> > If I were you, I'd look first into adding one for RS_NO_CLEAR_UA in
> > sys/dev/usb/umass.c.  See other quirks like this to get an idea.  It's
> > also possible that the problem is "NO_SYNC_CACHE" in
> > sys/cam/scsi/scsi_da.c.  I'm adding Kevin Oberman.  He's submitted some
> > quirks before.  The idea is to try a few similar to the surrounding ones
> > until something works.
>
> Whats the format of the quirk matching string?  I put this in (with a
> printf) but it doesnt match the device.
>
> --- scsi_da.c   Fri Aug  8 14:36:33 2003
> +++ /usr/src/sys/cam/scsi/scsi_da.c     Fri Aug  8 15:38:47 2003
> _at__at_ -364,6 +364,13 _at__at_
>                 {T_DIRECT, SIP_MEDIA_REMOVABLE, "MITSUMI", "USB FDD",
> "*"},
>                 /*quirks*/ DA_Q_NO_SYNC_CACHE
>         },
> +        {
> +                /*
> +                 * SigmaTel Pen Drives
> +                 */
> +                {T_DIRECT, SIP_MEDIA_REMOVABLE, "SigmaTel", "MSCN
> 0001", "*"},
> +                /*quirks*/ DA_Q_NO_SYNC_CACHE
> +        },
>  #endif /* DA_OLD_QUIRKS */
>  };

Try "SigmaTel", "MSCN", "*".  The 0001 is the version number, not part of
the product name.  Also, the "#endif" shows that you are putting your test
quirk under the #ifdef.  Instead it should come after the #endif so it
won't matter whether you're using "options DA_OLD_QUIRKS" or not.

-Nate