Re: M_NOTIFICATION in <sys/mbuf.h>?

> Hi,
>
> While trying to port the SCTP-KAME code to CURRENT,
> I noticed that M_NOTIFICATION is missing from <sys/mbuf.h>
> in CURRENT, but it is present in the KAME version of this
> file.
>
> Any reason not to apply this patch?
>
> --- sys/sys/mbuf.h.orig Sat Sep 13 19:34:07 2003
> +++ sys/sys/mbuf.h Sat Sep 13 19:34:14 2003
> _at__at_ -164,6 +164,8 _at__at_
>  #define M_FIRSTFRAG 0x1000 /* packet is first fragment */
>  #define M_LASTFRAG 0x2000 /* packet is last fragment */
>
> +#define M_NOTIFICATION 0x8000 /* notification event */
> +
>  /*
>   * External buffer types: identify ext_buf type.
>   */
>
> KAME guys have it here:
> http://orange.kame.net/dev/cvsweb.cgi/kame/freebsd5/sys/sys/mbuf.h?rev=1.5

The KAME snapshot of our source tree is 3 months out of date.  The most
recent version of mbuf.h is here:
http://www.freebsd.org/cgi/cvsweb.cgi/src/sys/sys/mbuf.h?rev=1.122&content-type=text/plain

We already have 0x8000 assigned, and the only free flags value is 0x4000 -- 
but it conflicts with other private usages in the kernel (as per the CVS
comments.)

Does SCTP-KAME really need a special flag value?

--
Matt Emmerton