Re: USB da(4) quirks deprecated

On Sat, 9 Aug 2003, Andrew Thompson wrote:
> On Fri, 2003-08-08 at 15:41, Nate Lawson wrote:
> I have applied Kevins DA_Q_NO_PREVENT patch and now the device is
> working perfectly, here is the diff and new dmesg.
>
> Thanks Nate and Kevin for your help.  Should I send a PR?

Please do and then send me the #.

> dmesg:
> umass0: SigmaTel, Inc. USBMSC Audio Player, rev 1.10/0.01, addr 3
> umass0: Get Max Lun not supported (IOERROR)
> Enabling quirks for device
> da0 at umass-sim0 bus 0 target 0 lun 0
> da0: <SigmaTel MSCN 0001> Removable Direct Access SCSI-4 device
> da0: 1.000MB/s transfers
> da0: 125MB (256001 512 byte sectors: 64H 32S/T 125C)

> scsi_da.c.diff:
> _at__at_ -228,6 +229,10 _at__at_
>                 {T_DIRECT, SIP_MEDIA_FIXED, quantum, "VIKING 2*", "*"},
>                 /*quirks*/ DA_Q_NO_6_BYTE
>         },
> +       {
> +               {T_DIRECT, SIP_MEDIA_REMOVABLE, "SigmaTel*", "MSCN*",
> "*"},
> +               /*quirks*/
> DA_Q_NO_6_BYTE|DA_Q_NO_SYNC_CACHE|DA_Q_NO_PREVENT
> +       },
>
>  #ifdef DA_OLD_QUIRKS
>         /* Below a list of quirks for USB devices supported by umass. */

The NO_PREVENT support has been added.  Does this work for you?
       {
           {T_DIRECT, SIP_MEDIA_REMOVABLE, "SigmaTel", "MSCN", "*"},
            /*quirks*/ DA_Q_NO_SYNC_CACHE|DA_Q_NO_PREVENT
       },

-Nate