buildworld doesn't like -O2

Thus spake Steve Kargl (sgk_at_troutmask.apl.washington.edu) [09/12/03 22:59]:
: -j# obfuscates where the actual error occurs unless you have
: enough make-fu to read the log.  The first step one should
: take when this type of error happens is a plain "make buildworld".
: The next step is run cvsup again to see if the problem has
: been fixed.  Then, report the error to freebsd-current.

Okay, after some playing around, it turns out that something in the PAM code
really doesn't like -O2 optimization -- I have CFLAGS=-O2 -pipe, and this is
what I see:

    ===> lib/libpam/modules/pam_echo
    cc -O2 -pipe -march=pentiumpro \
    -I/usr/src/lib/libpam/modules/pam_echo/../../../../contrib/openpam/include \
    -I/usr/src/lib/libpam/modules/pam_echo/../../libpam -Wsystem-headers \
    -Werror -Wall -Wno-format-y2k -W -Wstrict-prototypes \
    -Wmissing-prototypes -Wpointer-arith -Wreturn-type -Wcast-qual \
    -Wwrite-strings -Wswitch -Wshadow -Wcast-align -Wno-uninitialized  -c \
    /usr/src/lib/libpam/modules/pam_echo/pam_echo.c \
    /usr/src/lib/libpam/modules/pam_echo/pam_echo.c: In function `_pam_echo':
    /usr/src/lib/libpam/modules/pam_echo/pam_echo.c:92: warning:
    dereferencing type-punned pointer will break strict-aliasing rules
    *** Error code 1

    Stop in /usr/src/lib/libpam/modules/pam_echo.
    *** Error code 1

    Stop in /usr/src/lib/libpam/modules.
    *** Error code 1

    Stop in /usr/src/lib/libpam.
    *** Error code 1

    Stop in /usr/src.
    *** Error code 1

    Stop in /usr/src.
    *** Error code 1

    Stop in /usr/src.
    *** Error code 1

    Stop in /usr/src.

Yes, I'm aware the -O2 isn't supported.  World builds fine with just -O.
I'll just drop back to that.