Re: Fixing gcc 3.3 compile failures -- fix for net/netsaint-plugins

From: Thomas Dickey <dickey_at_radix.net>
Date: Tue, 22 Jul 2003 16:07:01 -0400
On Tue, Jul 22, 2003 at 02:56:37PM -0500, Jacques A. Vidrine wrote:
> On Tue, Jul 22, 2003 at 02:26:08PM +0200, Simon Barner wrote:
> 
> > --- plugins/check_by_ssh.c.orig	Mon Apr 23 09:43:11 2001
> > +++ plugins/check_by_ssh.c	Tue Jul 22 05:05:52 2003
> > _at__at_ -191,7 +191,7 _at__at_
> >  	if (commands>1)
> >  		remotecmd=strscat(remotecmd,";echo STATUS CODE: $?;");
> >  
> > -	if (strlen (remotecmd) <= 1)
> > +	if (remotecmd==NULL)
> >  		usage ("No remotecmd\n");
> >  
> >  	comm = ssprintf(comm,"%s %s '%s'",comm,hostname,remotecmd);
> 
> This looks like more than a fix for a `compile failure'.  The
> replacement code has different semantics than the new code.
> What is the `compile failure' that was being fixed here?

perhaps the compiler was pointing out that remotecmd may not be initialized.

(I don't see enough context to be sure ;-)

-- 
Thomas E. Dickey <dickey_at_radix.net> <dickey_at_herndon4.his.com>
http://dickey.his.com
ftp://dickey.his.com
Received on Tue Jul 22 2003 - 11:07:27 UTC

This archive was generated by hypermail 2.4.0 : Wed May 19 2021 - 11:37:16 UTC