At 2:29 PM -0500 6/11/03, Scot W. Hetzel wrote: >From: "Munehiro Matsuda" <haro_at_kgt.co.jp> > > I was having the same compile error, until I commeted out > > the BDECFLAGS definition from /etc/make.conf. > > > > Looking into the problematic Makefiles, I've found that > > following Makefiles do references BDECFLAGS, which matches > > errors I was getting: > > >> usr.sbin/config/Makefile : CFLAGS+= ${BDECFLAGS} >> usr.sbin/lpr/Makefile.inc: CWARNFLAGS= ${BDECFLAGS} >> usr.sbin/kgzip/Makefile : CFLAGS+= ${BDECFLAGS} >> > > I think these references must be removed. Ugh. Every time there's a scan for some bad-programming practice, 'lpr' is one of the guilty parties... I'll fix that one! >I did a find for BDECFLAGS and it found 5 Makefiles that >are adding these flags to either CFLAGS or CWARNFLAGS. > ># cd /usr/src ># find . -type f -exec grep -H "BDECFLAGS" {} + >./sbin/ffsinfo/Makefile:#CFLAGS+=${BDECFLAGS} >./sbin/growfs/Makefile:#CFLAGS+=${BDECFLAGS} >: >./usr.sbin/config/Makefile:CFLAGS+= ${BDECFLAGS} >./usr.sbin/lpr/Makefile.inc:CWARNFLAGS= ${BDECFLAGS} >./usr.sbin/kgzip/Makefile:CFLAGS+= ${BDECFLAGS} > >A couple of possible fixes are: > 1. removal of BDECFLAGS from the above files > 2. Add a .ifdef USE_BDECFLAGS .. .endif, that > conditionalizes the use of BDECFLAGS in the > above files. Ick. Then we'll need a "USE_USE_BDECFLAGS", to tell us if we should pay attention to the USE_BDECFLAGS variable... My guess is that there isn't a single reason that these five programs need to reference BDECFLAGS, especially now that it is no longer defined in /etc/defaults/make.conf . We should just remove those references. -- Garance Alistair Drosehn = gad_at_gilead.netel.rpi.edu Senior Systems Programmer or gad_at_freebsd.org Rensselaer Polytechnic Institute or drosih_at_rpi.eduReceived on Wed Jun 11 2003 - 11:17:18 UTC
This archive was generated by hypermail 2.4.0 : Wed May 19 2021 - 11:37:11 UTC