Bogus "temporary" gethostbyaddr_r() in libc for 6 years

From: Kris Kennaway <kris_at_obsecurity.org>
Date: Sun, 15 Jun 2003 18:54:59 -0700
There's a bogus implementation of gethostbyaddr_r() in
lib/libc/net/gethostnamadr.c that was committed 6 years and nine
months ago:

/*
 * Temporary function (not thread safe)
 */
int gethostbyaddr_r(const char *addr, int len, int type,
        struct hostent *result, struct hostent_data *buffer)
{
        struct hostent *hp;
        int ret;
        if ((hp = gethostbyaddr(addr, len, type)) == NULL) {
                ret = -1;
        } else {
                memcpy(result, hp, sizeof(struct hostent));
                ret = 0;
        }
        return(ret);
}

What's the deal here? Despite the fact that this is not prototyped in
a header, some ports are detecting this, and -- one assumes -- not
behaving correctly since this implementation isn't thread-safe.

Kris

Received on Sun Jun 15 2003 - 16:55:00 UTC

This archive was generated by hypermail 2.4.0 : Wed May 19 2021 - 11:37:12 UTC