Re: Ports broken due to -current change (Re: Ports broken on ia64)

[Moved to -standards, BCC'd to -current.]

Bruce Evans <bde_at_zeta.org.au> writes:
> On Sun, 18 May 2003, Kris Kennaway wrote:
> > http://bento.freebsd.org/errorlogs/i386-5-latest/gnu-finger-1.37.log
> >
> > In file included from os.c:24:
> > /usr/include/sys/stat.h:168: sizeof applied to an incomplete type
> > /usr/include/sys/stat.h:169: sizeof applied to an incomplete type
> > /usr/include/sys/stat.h:168: warning: width of `((anonymous))' exceeds its type
> > /usr/include/sys/stat.h:169: warning: width of `((anonymous))' exceeds its type

>From the URL above, it looks like this program also has a problem with
<sys/file.h>.  One would assume from the output that it specifies a
standard then uses a header outside of the standard (ie <sys/file.h>).

I think in the past we've labeled these as application problems, but
perhaps we might want to be a bit more accommodating to pseudo-
conformant applications (especially considering it usually only
requires an s/u_int/unsigned int/ and s/u_int(\d+)_t/uint$1_t/ in
userland headers).

> Untested fix:
[...patch to fix __BSD_VISIBLE misuse in <sys/stat.h>...]
> 
> "find /usr/include/ | grep _VISIBLE | egrep(ifdef|ifndef|defined)"
> shows similar bugs in <math.h>.

I'm seeking commit approval to fix both of these.

Best regards,
Mike Barcroft