Re: SMP kernel panic with traceback

On Thu, 18 Sep 2003, Bruce Evans wrote:

> On Wed, 17 Sep 2003, Daniel Eischen wrote:
> 
> > I'm getting crashes when trying to debug mozilla (under KSE).
> > The panic message is "panic: absolutely cannot call smp_ipi_shootdown
> > with interrupts already disabled".  Attached is the trace.
> > Any ideas?
> 
> Eeek.  Looks like I forgot an attachment to i386/machdep.c 1.468 2001/08/13
> (use interrupt gates instead of trap gates for breakpoint and trace traps).
> Keeping interrupts disabled is only correct for these traps if they are
> from kernel mode.  It's surprising how few problems this has caused.
> 
> %%%
> Index: trap.c
> ===================================================================
> RCS file: /home/ncvs/src/sys/i386/i386/trap.c,v
> retrieving revision 1.256
> diff -u -2 -r1.256 trap.c
> --- trap.c	15 Aug 2003 15:20:27 -0000	1.256
> +++ trap.c	16 Aug 2003 00:32:07 -0000
> _at__at_ -275,4 +318,5 _at__at_
>  		case T_BPTFLT:		/* bpt instruction fault */
>  		case T_TRCTRAP:		/* trace trap */
> +			enable_intr();
>  			frame.tf_eflags &= ~PSL_T;
>  			i = SIGTRAP;
> %%%

Thanks, I'll try it tonight when I get access to the box again.

-- 
Dan Eischen