RFC: ported NetBSD if_bridge

Hi,


I have ported over the bridging code from NetBSD and am looking for feedback.
My main question is, 'do people want this in the tree?'


The benefits over the current bridge are:
 * ability to manage the bridge table
 * spanning tree support
 * the snazzy brconfig utility
 * clonable pseudo-interface (is that a benefit?)


I need a bit of help on the following:
 * testing
 * the header includes, I have made a mess of them :)
 * locking?
 * updating the brconfig man page
 * some way to support the sysctl net.link.ether.bridge.config (?)


You will need to rebuild your kernel as some structs have changed, then
# cd /sys/modules/if_bridge
# make && make install
# cd /usr/src/sbin/brconfig
# make && make install
# kldload if_bridge
# ifconfig bridge0 create
# brconfig bridge0 add <if1> add <if2>


The attached diff is for todays current, and is also available _at_
http://www.fud.org.nz/~andy/if_bridge.diff


Comments welcome, good or bad.


cheers,

Andrew