Re: TEST/REVIEW ng_ether/ng_pppoe/ppp

Bjoern A. Zeeb wrote:
> Hi,
> 
> I have added some functionality to ng_ether / ng_pppoe that is needed
> for running multiple pppoe sessions over one single NIC even if
> the AC uses s.th. like 'pppoe duplicate-protection' [1].
> 
> I have seperated the patches for easier review and tried to do it in
> a manner so that parts can be used for other things too (at least the
> ng_ether one). I also updated the man pages to reflect these changes.
> 
> Here are the patches:
> 
> 
> http://sources.zabbadoz.net/freebsd/patchset/10005-net-netgraph-ether.diff
> 


this comment and the code disagree....
+	/* If "promisc" hook not connected, let packet continue */
+	if (priv->lower == NULL || priv->lowerType!=LOWER_TYPE_PROMISC) {
+		m_freem(m);
+		return;
+	}


if not connected.. discarded....

In the documentation:
+written to the hook. The interface has to be put into promiscuous before
+by using p.ex.
+.Dv NGM_ETHER_SET_PROMISC .
+Normal incoming traffic is unaffected.

what is the "p.ex" ?


> ! Description:  hook for ng_ether to receive unicast packets to a
> !               different Ethernet address than the one of the interface.
> 
> 
> http://sources.zabbadoz.net/freebsd/patchset/10006-netgraph-pppoe.diff
> 
> ! Description:  2 extensions to ng_pppoe:
> !               + in addition to AC NAME also report AC MAC to userspace
> !               + add the ability to give a MAC as source MAC for the
> !                 session when connecting
> 
> 


looks ok from a quick look...

what are you doing with these?
have you tested teh pppoe with:
1/ pppoed
2/ ppp  (obviously yes from your patch below)
3/ mpd

to check that it does not cause regressions?




> Please review and commit if you like it.
> 
> 
> I have tested both for some weeks now with following patch to ppp(8).
> It needs a lot more review but may be good enough for testing.
> Comments/diffs/improved versions on this one welcome.
> 
> http://sources.zabbadoz.net/freebsd/patchset/10008-usr-sbin-ppp-pppoe-smac.diff


hmmm, I see,, very interesting...

you should  make an attempt to contact brian
> 
> ! Description:  extend ppp to make use of patch 10006 (set source MAC
> !               for pppoe session).
> !
> ! Remarks:      hopefully seperated patch correctly from 10007;
> !               I am almost sure this patch will break something else.
> 
> [it will most likely not apply cleanly without patch 10007 - see other
> mail to current_at_ ]
> 
> 
> 
> [1] http://juniper.net/techpubs/software/erx/erx50x/swconfig-link/html/pppoe-config5.html#123643
> 


-- 
+------------------------------------+       ______ _  __
|   __--_|\  Julian Elischer         |       \     U \/ / hard at work in
|  /       \ julian_at_elischer.org     +------>x   USA    \ a very strange
| (   OZ    )                                \___   ___ | country !
+- X_.---._/    presently in San Francisco       \_/   \\
           v