Problems with power button after latest acpi_button.c 1.18 change

From: Rudolf Cejka <cejkar_at_fit.vutbr.cz>
Date: Wed, 18 Feb 2004 20:04:39 +0100
Hello,
  after latest change to src/sys/dev/acpica/acpi_button.c, revision 1.18,
I have problems with power-button on my Asus L4000L notebook, now it works
just in some cases:
    System boot -> Press Power button -> Nothing happens = bad
However:
    System boot -> Press Fn+Zz -> System is sleeping -> Space -> System is
      running again -> Press Power button -> Systems goes down - ok

After reverting part of 1.18 change (see below), power button does work
again in all cases. Are you interested in some output from my notebook?
Do you know about notebooks, for which it helps and for which it breaks
something as for my Asus?
Thanks.

--- sys/dev/acpica/acpi_button.c.orig	Wed Feb 18 10:38:18 2004
+++ sys/dev/acpica/acpi_button.c	Wed Feb 18 10:43:44 2004
_at__at_ -147,22 +147,6 _at__at_
     }
     acpi_device_enable_wake_capability(sc->button_handle, 1);
 
-    /*
-     * If we have fixed buttons defined in the FADT, remove them now that
-     * we have found one in the AML.  Some systems define buttons both ways
-     * but only deliver events to the AML object.
-     */
-    if (event == ACPI_EVENT_POWER_BUTTON && AcpiGbl_FADT->PwrButton == 0) {
-	AcpiDisableEvent(event, 0);
-	AcpiClearEvent(event);
-	AcpiRemoveFixedEventHandler(event, acpi_event_power_button_sleep);
-    }
-    if (event == ACPI_EVENT_SLEEP_BUTTON && AcpiGbl_FADT->SleepButton == 0) {
-	AcpiDisableEvent(event, 0);
-	AcpiClearEvent(event);
-	AcpiRemoveFixedEventHandler(event, acpi_event_sleep_button_sleep);
-    }
-
     return_VALUE (0);
 }

-- 
Rudolf Cejka <cejkar at fit.vutbr.cz> http://www.fit.vutbr.cz/~cejkar
Brno University of Technology, Faculty of Information Technology
Bozetechova 2, 612 66  Brno, Czech Republic
Received on Wed Feb 18 2004 - 10:04:43 UTC

This archive was generated by hypermail 2.4.0 : Wed May 19 2021 - 11:37:43 UTC