Re: kernel dev_t elimination patch for review

From: Bruce Evans <bde_at_zeta.org.au>
Date: Fri, 11 Jun 2004 21:16:06 +1000 (EST)
On Fri, 11 Jun 2004, Poul-Henning Kamp wrote:

> 	http://phk.freebsd.dk/patch/dev_t.patch
>
> This patch changes "dev_t" in the kernel to "struct cdev *"
> and is 337K of boredom like:
>
> 	-static dev_t perfdev;
> 	+static struct cdev *perfdev;
>
> People who maintain cross-platform or cross-version source code in
> the kernel, should take a close look at this patch.
>
> If you don't like the way I have done it (which is mostly automated)
> you are more than welcome to commit your own patch, all you have
> to do is use "struct cdev *" instead of "dev_t", and you can do
> that already now.

This mangles the formatting in approximately 10% of cases (mainly for
dev_t\t\t and for almost all dev_t's in structs; in structs it tends
to misindent both the member name and the comment).

Bruce
Received on Fri Jun 11 2004 - 09:16:40 UTC

This archive was generated by hypermail 2.4.0 : Wed May 19 2021 - 11:37:56 UTC