Re: New preview patch for ipfw to pfil_hooks conversion

From: Maxim Konovalov <maxim_at_macomnet.ru>
Date: Tue, 22 Jun 2004 13:35:18 +0400 (MSD)
On Tue, 22 Jun 2004, 02:06-0700, Luigi Rizzo wrote:

> On Tue, Jun 22, 2004 at 12:15:21PM +0400, Maxim Konovalov wrote:
> ...
> > > Consider this a FYI.  It is very much a WIP at the moment.  I want
> > > to get this into the tree in before 5.3 code freeze.
> >
> > In fact, our real world tests shown the current -CURRENT comparing to
> > RELENG_5_2 is in a very bad shape.  Is it really worth to commit that
> > mostly cleanup code before say 6-CURRENT with a chance to
>
> of course it is! i also do not follow the reasoning -- given that it is
> cleaning up code, it is only welcome at any stage except perhaps
> in code freeze.

My concern is bugs.  Especially in cleanup code, especially in
ip_pcbopt and ip_reass.

> plus, is the 'bad shape' related at all to what andre posted ?

'bad shape' is related to 5-CURRENT we are trying to make -STABLE.

-- 
Maxim Konovalov
Received on Tue Jun 22 2004 - 07:35:54 UTC

This archive was generated by hypermail 2.4.0 : Wed May 19 2021 - 11:37:58 UTC