Re: New preview patch for ipfw to pfil_hooks conversion

On Tue, 22 Jun 2004, 13:38+0200, Andre Oppermann wrote:

> Maxim Konovalov wrote:
> >
> > Hi Andre,
> >
> > On Mon, 21 Jun 2004, 23:36+0200, Andre Oppermann wrote:
> >
> > > Here is the next preview patch for the ipfw to pfil_hooks conversion:
> > >
> > >  http://www.nrg4u.com/freebsd/ipfw-pfilhooks-and-more-20040621.diff
> > >
> > > This patch significantly cleans up ip_input.c and ip_output.c.
> >
> > Is it possible to split that ~100KB patch in a logic chunks?  One for
> > phil_hook, one for ip_pcbopt, one for ip_reass etc.  Much easier to
> > review and commit them later.
>
> Of course it will be split up.  I haven't done this because this is
> only a preview patch of work in progress.

Please HEADSUP us before commit or drop me a note, I am willing to
review reass/ip options code as I spent a lot of hours parsing it.

As a side note, what is "#define MAX_IPOPTLEN    40" in
ip_options.h for?  There is one in ip_var.h.

-- 
Maxim Konovalov