On Sun, Jun 27, 2004 at 05:29:23PM +0000, Bjoern A. Zeeb wrote: +> some more points while skipping through the code a second time: +> +> * could we make this +> strlcpy(sp->f_mntonname, "<restricted>", +> s.th. w/o '<' and '>' ? [] or () would make me feel better as +> those though special characters won't redirect anything in sh +> even if we should never see this. Ok, will do. +> * in fhstatfs you missed a prison_enforce_statfs call Nope. It is placed in cvtstatfs(). +> * some spelling/grammer left to someone else Yeah. +> else looks good to me; didn't check the compat code; +> going to see if I can build a kernel and setup some jails on a +> test machine to see if it works as well. Thanks! -- Pawel Jakub Dawidek http://www.FreeBSD.org pjd_at_FreeBSD.org http://garage.freebsd.pl FreeBSD committer Am I Evil? Yes, I Am!
This archive was generated by hypermail 2.4.0 : Wed May 19 2021 - 11:37:59 UTC