Re: proposed bsdlabel patch

From: Luigi Rizzo <rizzo_at_icir.org>
Date: Mon, 29 Mar 2004 23:06:43 -0800
On Mon, Mar 29, 2004 at 04:50:13PM -0800, Marcel Moolenaar wrote:
> On Mon, Mar 29, 2004 at 04:39:26PM -0800, Luigi Rizzo wrote:
> > if there are no strong objections, I'd like to commit
> > the following minor patch to bsdlabel (and associated bsdlabel.8
> > changes) to implement a '-f' option which enables bsdlabel to
> > work on an image file too.
> 
> As Julian mentioned, why not use stat(2) and DTRT without options?
> That also removes the gratuitous requirement that the filename has
> to be an absolute path. See also the implementation of gpt(8)...

sure, will do that, and take care of the style bugs as bruce
suggested (the original patch was voluntarily formatted in
a way to reduce the diffs).

thanks for the feedback
cheers
luigi
Received on Mon Mar 29 2004 - 21:06:44 UTC

This archive was generated by hypermail 2.4.0 : Wed May 19 2021 - 11:37:49 UTC