Re: Updated SATA support patches for Intel ICH & Promise cards

David Schultz wrote:
> On Tue, May 04, 2004, Sren Schmidt wrote:
> 
>>Doug Ambrisko wrote:
>>
>>>These patches have been updated to -current as of the past weekend.
>>>They increase the robustness of SATA disk errors (media errors and
>>>drive going away such as drives that spin up and down).  Also has
>>>code to support hot swap on both controllers.
>>>
>>>This is only HW support and does not address other ata/FreeBSD issues.
>>>That isn't quite right ... some ata changes have been made to avoid
>>>panics in probes etc. to support the HW changes.
> 
> [...]
> 
>>I'm sorry if this sounds a bit harsh, but your work conflicts pretty 
>>much head on with the way I want this to move along. However code to 
>>read/write the RAID config (AMI way I'd guess) would be welcomed as I 
>>only have the descriptions for that done, but no code yet...
> 
> The ata driver has not worked with my hardware for months, as I
> reported to you last September.  With Doug's patches, things work
> perfectly.  Therefore, I'd really appreciate it if you gave more
> consideration to his work.  I would be happy to help merge them
> with your changes if you'll allow me.

What is your exact problem again ? I dont recall the details and my mail 
archive is not online sorry..

Now, I do have changes here locally that fixes the problems at hand, and 
they will be committed in the not too distant future, but there are a 
couble of issues with the software RAID part thats not resolved yet and 
that I'd like to fix first. That is now possible since I have the HW 
here to play with, I'm sorry if that took too long, but I dont have 
endless resources, and have to rely on sponsors etc for that kind of 
support to materialize.

These patches are not really combineable since I've done things 
differently and IMHO the way ATA wants it. What I would find usefull 
would be the code to handle the AMI? RAID type as I havn't got any HW 
with that one handy to test on, but if thats not to be unless the patch 
at hand goes in, well...

BTW doug's patches doesn't solve the missing interrupt problem unless 
I've missed it in the patch.

-- 
-Søren