NO_WERROR: correct usage?

From: Conrad J. Sabatier <conrads_at_cox.net> Date: Mon, 8 Nov 2004 22:38:15 -0600 · This archive was generated by hypermail 2.4.0 : Wed May 19 2021 - 11:38:21 UTC

The description in /usr/src/UPDATING re: the use of NO_WERROR seems to
be incorrect:

20020815:
        A "bug" in gcc(1) that was hiding warning in system headers was
        fixed.  It's probably time to add -DNO_WERROR to your make line
        again.

Adding "-DNO_WERROR" to CFLAGS in /etc/make.conf seems to have no
effect; the "-Werror" switch still gets added at certain places during
the build.

On the other hand, defining NO_WERROR as a make variable in
/etc/make.conf does seem to work, like so:

NO_WERROR=true

In addition, for kernel builds, it appears that it is necessary to 
define:

WERROR=-Wno-error 

I believe some clarification somewhere (in/usr/src/UPDATING,
/usr/share/examples/etc/make.conf, or /usr/src/Makefile) would be
helpful.

-- 
Conrad J. Sabatier <conrads_at_cox.net> -- "In Unix veritas"