Re: Commitable R3000Z Patch!

I think you actually need the device, for the keyboard on the machine
to work. Its just the testing that breaks in this case. I'm not
certain. Like I said, this has mostly come out of a desire on my part,
to no longer maintain a fork that consists of 2 lines of code.

--- Harrison Grundy


On Thu, 11 Nov 2004 10:40:40 -0800, John-Mark Gurney
<gurney_j_at_resnet.uoregon.edu> wrote:
> Astrodog wrote this message on Thu, Nov 11, 2004 at 09:48 -0600:
> > Any hint will do, honestly. Just altering the patch to reflect the
> > change will work. I'd like to automate it by detecting the mobile
> > nforce3 chipsets, but I don't even know where to start with that yet.
> > Any suggestions?
> 
> Why don't you fix the real problem, which is that atkbdc_configure is
> called from atkbd_configure even when the device is disabled?  Why not
> fix atkbd_configure to just bail out if the reousrce is disabled?
> 
> 
> 
> > On Thu, 11 Nov 2004 07:31:14 -0800, Brooks Davis
> > <brooks_at_one-eyed-alien.net> wrote:
> > > On Thu, Nov 11, 2004 at 05:55:20AM -0800, Astrodog wrote:
> > >
> > >
> > > > The patch is located at
> > > > http://evogaming.il.us.tveps.net/~astrodog/atkbdc.patch testing was
> > > > quite limited, but essentally, if you set hint.atkbd.0.disabled to 1,
> > > > it disables the test. I suppose it could be renamed to any number of
> > > > things, the code is a whole 2 lines, and is quite obvious. I'm gonna
> > > > wait to see if it makes -CURRENT in the next day or so, so I don't end
> > > > up with people grabbing ISOs from me if I don't have to (Snapshots
> > > > servers are your freind). Automatic detection code to follow in the
> > > > next day or so. This was tested on a Compaq 3004US, and it solved the
> > > > reboot problem. I also tested on a dual opteron 240 machine, and when
> > > > the hint is not set, it has no effect. I'm going to double-post to
> > > > freebsd-current in hopes of getting it committed sooner, so all of us
> > > > 3000Z-base laptop owners can have our fun with FreeBSD.
> > >
> > > Do you really have to use this hint?  You're changing the meaning of
> > > only one disabled flag which we're trying to make consistant.  If that's
> > > all you can use at that point, we'll live, but it seems ugly.
> 
> -- 
>   John-Mark Gurney                              Voice: +1 415 225 5579
> 
>      "All that I will do, has been done, All that I have, has not."
>