Re: ACPI suspend/ ATA reboots

On Sunday 10 October 2004 05:06 am, you wrote:
> Anish Mistry wrote:
> > On Saturday 09 October 2004 01:19 pm, Anish Mistry wrote:
> >>Running 6-CURRENT. Between 09.25.18.00.00 UTC and 09.26.12.00.00 UTC some
> >>commit seemed to break suspending on my laptop.  Whenever I try to
> >> suspend it reboots.  Before this suspend was working well.  The panic
> >> message seem to indicate an ATA issue.
> >>http://am-productions.biz/docs/littleguy.asl.gz
> >>http://am-productions.biz/docs/littleguy-dmesg.boot.gz
> >
> > I've narrowed it down to the 20 minute period from 09.26.11.40.00 UTC -
> > 09.26.12.00.00 UTC and the ATA commit with "Remove the old ATA_*LOCK_CH
> > macros" seems to be causing it.
>
> Hmm, since I cannot test it here as suspend/resume has been broken since
> mid august on all my laptops I cant help you other than suggesting that
> you backstep ACPI as that works for me...
I just cvsup'd again, and the following commit seems to fix it:
sos         2004-10-10 13:24:39 UTC

  FreeBSD src repository

  Modified files:
    sys/dev/ata          ata-all.c 
  Log:
  Dont sleep with lock held.
  
  Revision  Changes    Path
  1.231     +1 -1      src/sys/dev/ata/ata-all.c

Thanks,
-- 
Anish Mistry