Re: rigth crc32 implementation

El Miércoles, 27 de Abril de 2005 07:38, Tim Kientzle escribió:
> Jose M Rodriguez wrote:
> > El Miércoles, 27 de Abril de 2005 00:19, Marcel Moolenaar 
escribió:
> >>On Tue, Apr 26, 2005 at 01:01:32PM -0700, Sam Leffler wrote:
> >>>Note also there is CRC32 code of this sort in WEP and TKIP crypto
> >>>modules in the net80211 support.
> >>
> >>Given the seperation of crc32() into crc32_raw() and crc32(), with
> >>either crc32() only or otherwise both functions inlined, are there
> >>any obstacles preventing the 802.11 code from using the ones in
> >>src/sys/libkern?
> >
> > at last, sys/dev/if_sbni have another implementation of what seems
> > to be a crc32 alg.
>
> Be a little careful, please.  There are very many
> different, incompatible "32-bit CRCs."  There are
> just a few popular ones, so you can often combine
> functions, but not always.
>

I'm getting this.

I'll try to do some test and notes.

I think that a regression test may show what is and what is not the 
ether CRC-32.

At the moment, I'll go private with
- CRC_INIT, CRC_DO, CRC_GET macros
- An implementation in the way of crc32(), crc32_raw(), but avoiding 
symbol collission.

And go to libkern through the macros if doable.

--
  josemi