Re: ATA mkIII first official patches - please test!

From: Søren Schmidt <sos_at_DeepCore.dk>
Date: Mon, 07 Feb 2005 15:32:31 +0100
Arne Schwabe wrote:
> Søren Schmidt <sos_at_DeepCore.dk> writes:
> 
> 
>>Randy Bush wrote:
>>
>>>>>After suspend, my ThinkPad X40 now hangs with following logs (copied
>>>>>by hand):
>>>>
>>>>Hmm, do you have ATA compiled in or as modules. I could easily
>>>>imagine that modules could have problems, but as "built in" nothing
>>>>really changed...
>>>
>>>my patched t41, current with ata in the kernel, locks up with disk
>>>light on solid on resume.
>>
>>Does it work with stock ATA ?
>>I cant work on suspend/resume as it has been broken due to ACPI 
>>brokenness since september last year on all my laptops...
> 
> 
> Same here, worked before the patch. Does not work with the patch.

Hmm, the attached patch is the only real difference, which actually 
shouldn't pose a problem (and fixes broken APM)..

Let me know if that changes anything, other than that you are free to 
bug the ACPI gang to make ACPI work on the HW I have available for 
development...


-Søren


diff -u -r1.20 ata-all.c
--- ata-all.c   2005/02/03 17:02:31     1.20
+++ ata-all.c   2005/02/07 14:27:57
_at__at_ -630,7 +630,7 @@
 void
 ata_udelay(int interval)
 {
-    if (1 || interval < (1000000/hz) || ata_delayed_attach)
+    if (interval < (1000000/hz) || ata_delayed_attach)
        DELAY(interval);
     else
        tsleep(&interval, PRIBIO, "ataslp", interval/(1000000/hz));
Received on Mon Feb 07 2005 - 13:32:54 UTC

This archive was generated by hypermail 2.4.0 : Wed May 19 2021 - 11:38:27 UTC