RFC: Inverse KASSERT in sys/dev/usb/ohci.c:1.150 ?

From: Giorgos Keramidas <keramida_at_freebsd.org>
Date: Wed, 5 Jan 2005 15:12:53 +0200
The KASSERT that replaces an explicit if conditional in ohci.c:1.150
causes a panic here when I try to use my USB flash disk:

% -#ifdef DIAGNOSTIC
% -                        if (curlen == 0)
% -                                panic("ohci_alloc_std: curlen == 0");
% -#endif
% +                        KASSERT ((curlen == 0), ("ohci_alloc_std: curlen == 0"));

Shouldn't the KASSERT expression have inverse logic, i.e.:

	KASSERT((curlen != 0), ("ohci_alloc_std: curlen == 0"));

- Giorgos
Received on Wed Jan 05 2005 - 12:12:56 UTC

This archive was generated by hypermail 2.4.0 : Wed May 19 2021 - 11:38:25 UTC