Re: RFC: Inverse KASSERT in sys/dev/usb/ohci.c:1.150 ?

From: Maxime Henrion <mux_at_freebsd.org>
Date: Wed, 5 Jan 2005 14:28:00 +0100
Giorgos Keramidas wrote:
> The KASSERT that replaces an explicit if conditional in ohci.c:1.150
> causes a panic here when I try to use my USB flash disk:
> 
> % -#ifdef DIAGNOSTIC
> % -                        if (curlen == 0)
> % -                                panic("ohci_alloc_std: curlen == 0");
> % -#endif
> % +                        KASSERT ((curlen == 0), ("ohci_alloc_std: curlen == 0"));
> 
> Shouldn't the KASSERT expression have inverse logic, i.e.:
> 
> 	KASSERT((curlen != 0), ("ohci_alloc_std: curlen == 0"));

Yes, it indeed should.

Cheers,
Maxime
Received on Wed Jan 05 2005 - 12:28:00 UTC

This archive was generated by hypermail 2.4.0 : Wed May 19 2021 - 11:38:25 UTC